Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter send-report using multiple selectors #1686

Open
stuartjd-lendable opened this issue Aug 29, 2024 · 1 comment
Open

Filter send-report using multiple selectors #1686

stuartjd-lendable opened this issue Aug 29, 2024 · 1 comment

Comments

@stuartjd-lendable
Copy link

stuartjd-lendable commented Aug 29, 2024

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

This is my understanding from some experimentation/testing but please let me know if there's a way to do this already.

Currently you can run the command edr send-report --select last_invocation which will filter the summary of the report to the last dbt execution. Alternatively you can run edr send-report --select tag:XYZ which will filter based on last 7 days (?) based on the tag selection.

However, running edr send-report --select last_invocation,tag:XYZ just sends the same thing as edr send-report --select last_invocation so there's no additional filtering going on.

Describe the solution you'd like
A clear and concise description of what you want to happen.

It would be really useful to be able to apply selectors like in dbt selectors with the comma , meaning the intersection of the selectors i.e. edr send-report --select last_invocation,tag:XYZ would filter the summary to the last invocation and for tag XYZ.
Same applies with filtering on last_invocation and the owners metadata etc.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Would you be willing to contribute this feature?
Let us know if you're willing to contribute so that we'll be able to provide guidance.

I've had a quick look at the code and feel might be solved by updates to this set of if/elif conditions that rules out the possibility of multiple matches. I dont have time to familiarise enough with the codebase to know whether this is the solution or if there's a neater way of doing this.

@ofek1weiss
Copy link
Contributor

Hey @stuartjd-lendable , the report only supports the last_invocation, invocation_id and invocation_time selectors.
after creating the report, you can filter the dashboard/results by tag inside of the report itself

@ofek1weiss ofek1weiss self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants