Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT Columns for source contains only column that have a description #1668

Closed
olivierdet opened this issue Aug 12, 2024 · 3 comments
Closed
Labels
Bug Something isn't working Triage 👀

Comments

@olivierdet
Copy link

olivierdet commented Aug 12, 2024

Describe the bug
DBT columns for source only contains column that have a documentation

To Reproduce
1 - Define tables inside sources
2 - Create 2 columns, one with description the other without
Only the column with description will appear in dbt_columns

We have something like

version: 2

sources:
    tables:
      - name: customer
        columns:
          - name: email
            description: Professional email
          - name: first_name
            meta:
              database_tags:
                data_classification: "level_2"

Email appear in dbt_columns, first_name not

Expected behavior

I would expect to have the 2 columns.

Environment (please complete the following information):

  • Elementary CLI (edr) version: 0.16.1
  • Elementary dbt package version: 0.16.0
  • dbt version you're using 1.8.5
  • Data warehouse Snowflake, drivers 1.8.3

Would you be willing to contribute a fix for this issue?
Yes, I can help if needed, just don't know where it is located

@olivierdet olivierdet added Bug Something isn't working Triage 👀 labels Aug 12, 2024
@IDoneShaveIt
Copy link
Collaborator

Hey @olivierdet, thanks for raising that up!
This is actually an intended behaviour that we have.
By default we only upload columns that have description, but we have a way to control it 🙂

In order to upload all columns, you should set the var upload_only_columns_with_descriptions: false

@IDoneShaveIt
Copy link
Collaborator

IDoneShaveIt commented Aug 15, 2024

I am closing this issue 🙂
Please let us know if you still have any question / something is still not working for you 🙏🏻

@olivierdet
Copy link
Author

Thanks, it works.
I don't find it anywhere in the documentation. Is it intended ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Triage 👀
Projects
None yet
Development

No branches or pull requests

2 participants