Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elementary runs hooks even when everything is disabled. #1581

Open
lfpll opened this issue Jul 3, 2024 · 0 comments
Open

Elementary runs hooks even when everything is disabled. #1581

lfpll opened this issue Jul 3, 2024 · 0 comments
Labels
Bug Something isn't working Triage 👀

Comments

@lfpll
Copy link

lfpll commented Jul 3, 2024

Describe the bug
It's not possible to really disable the elementary hooks, even if you disable all the autoupdates the hook will still run.

To Reproduce

Save your dbt_project.yml in

vars:
  disable_run_results: true
  disable_freshness_results: true
  disable_tests_results: true
  disable_dbt_artifacts_autoupload: true
  disable_dbt_columns_autoupload:  true
  disable_dbt_invocation_autoupload: true

Have the elementary enabled and run, this will still show the on-run-start

The option is running

elementary:
        enable: false

The problem with this is that I have to many models and my elementary breaks.

Expected behavior
I want to be able to run elementary manually and not run any hooks.

Environment (please complete the following information):

  • Elementary dbt package version: 1.5.3
  • dbt version you're using: 1.6.7
  • Data warehouse: Bigquery
  • Infrastructure details: Linux containareized python 3.9

Suggestion

on-run-start:
  - "{{ elementary.on_run_start() if env_var('DISABLE_ELEMENTARY_HOOKS','false') != 'true' else None}}"
on-run-end:
  - "{{ elementary.on_run_end() if env_var('DISABLE_ELEMENTARY_HOOKS','false') != 'true' else None}}"

This if worked would solve the problem.

@lfpll lfpll added Bug Something isn't working Triage 👀 labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Triage 👀
Projects
None yet
Development

No branches or pull requests

1 participant