Skip to content

Commit bfb197c

Browse files
authored
Fix typo in error message when a media ID isn't known (#17865)
1 parent f387f47 commit bfb197c

File tree

6 files changed

+7
-6
lines changed

6 files changed

+7
-6
lines changed

changelog.d/17865.misc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Addressed some typos in docs and returned error message for unknown MXC ID.

synapse/media/media_repository.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ async def verify_can_upload(self, media_id: str, auth_user: UserID) -> None:
259259
"""
260260
media = await self.store.get_local_media(media_id)
261261
if media is None:
262-
raise SynapseError(404, "Unknow media ID", errcode=Codes.NOT_FOUND)
262+
raise NotFoundError("Unknown media ID")
263263

264264
if media.user_id != auth_user.to_string():
265265
raise SynapseError(

synapse/rest/media/upload_resource.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ def _get_file_metadata(
9494

9595
# if headers.hasHeader(b"Content-Disposition"):
9696
# disposition = headers.getRawHeaders(b"Content-Disposition")[0]
97-
# TODO(markjh): parse content-dispostion
97+
# TODO(markjh): parse content-disposition
9898

9999
return content_length, upload_name, media_type
100100

tests/rest/admin/test_federation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def test_invalid_parameter(self) -> None:
9696
self.assertEqual(400, channel.code, msg=channel.json_body)
9797
self.assertEqual(Codes.INVALID_PARAM, channel.json_body["errcode"])
9898

99-
# unkown order_by
99+
# unknown order_by
100100
channel = self.make_request(
101101
"GET",
102102
self.url + "?order_by=bar",

tests/rest/admin/test_statistics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def test_invalid_parameter(self) -> None:
8282
"""
8383
If parameters are invalid, an error is returned.
8484
"""
85-
# unkown order_by
85+
# unknown order_by
8686
channel = self.make_request(
8787
"GET",
8888
self.url + "?order_by=bar",

tests/rest/admin/test_user.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ def test_invalid_parameter(self) -> None:
719719
self.assertEqual(400, channel.code, msg=channel.json_body)
720720
self.assertEqual(Codes.INVALID_PARAM, channel.json_body["errcode"])
721721

722-
# unkown order_by
722+
# unknown order_by
723723
channel = self.make_request(
724724
"GET",
725725
self.url + "?order_by=bar",
@@ -3696,7 +3696,7 @@ def test_limit_and_from_DELETE(self) -> None:
36963696
@parameterized.expand(["GET", "DELETE"])
36973697
def test_invalid_parameter(self, method: str) -> None:
36983698
"""If parameters are invalid, an error is returned."""
3699-
# unkown order_by
3699+
# unknown order_by
37003700
channel = self.make_request(
37013701
method,
37023702
self.url + "?order_by=bar",

0 commit comments

Comments
 (0)