Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected grey "authenticity cannot be guaranteed" warnings #3352

Open
ara4n opened this issue Sep 30, 2024 · 0 comments
Open

Unexpected grey "authenticity cannot be guaranteed" warnings #3352

ara4n opened this issue Sep 30, 2024 · 0 comments
Labels
A-E2EE Encryption O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@ara4n
Copy link
Member

ara4n commented Sep 30, 2024

Steps to reproduce

  1. Receive new e2ee msgs
  2. They have unexpected grey (i) warnings on them
  3. Tapping on warning gives "authenticity cannot be guaranteed on this device or so"

However, the authenticity should be fine as they shouldn't have been fished out of backup or otherwise gossipped.

This is particularly bad if the grey warning eclipses the fact that the message came from an unverified device, and so should have a red warning.

This is a rust-sdk bug: matrix-org/matrix-rust-sdk#3703 hopefully fixed by matrix-org/matrix-rust-sdk#4040 but filing here at the app-layer for tracking purposes and to confirm that the SDK fix actually works.

Outcome

What did you expect?

App should prioritise the trust of message keys received via Olm from the sender over the trust of keys fished out of backup.

What happened instead?

Presumably it raced, fished them out of backup, and then didn't update the shields later.

Your phone model

No response

Operating system version

No response

Application version

718

Homeserver

matrix.org

Will you send logs?

Yes
@ara4n ara4n added the T-Defect label Sep 30, 2024
@ara4n ara4n mentioned this issue Sep 30, 2024
Open
@pixlwave pixlwave added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-E2EE Encryption X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE Encryption O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ara4n @pixlwave