Skip to content

Encryption Settings | Reset Identity can take long if there are a lot of keys and there is no feedback, and possible to click the button several times #29192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
BillCarsonFr opened this issue Feb 5, 2025 · 4 comments · Fixed by #29388
Assignees
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Feb 5, 2025

Actions

  • Add a spinner when you click Continue as per the comment below

Description

Given an account with at least 20k keys cached and uploaded to an exisiting backup.

If you go to Settings > Encryption then click Reset cryptographic identity and then continue.

Image Image

Actual

Nothing will happen for 15/20s. There is no feedback that the reset process has started.
You can click several times on the continue button, this will lead to a broken state were you will be asked to enter account password several times.

Expected

This is due to an existing issue with indexeddb performance when resetting backup.

After clicking on the continue button, there should be:

Tasks

@dosubot dosubot bot added A-E2EE A-Storage Storage layer of the app, including IndexedDB, local storage, etc. O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect labels Feb 5, 2025
@mxandreas
Copy link

@americanrefugee Has proposed the following designs. These will be used to mitigate the issue short-term until the performance issue gets solved (it could be that this is useful even the performance gets improved).

Image

@dbkr dbkr removed the A-Storage Storage layer of the app, including IndexedDB, local storage, etc. label Feb 10, 2025
@uhoreg uhoreg self-assigned this Feb 26, 2025
@uhoreg
Copy link
Member

uhoreg commented Feb 28, 2025

@americanrefugee The mockup at https://www.figma.com/design/ZodBLtGnKmRTGJo5SGLnH3/ER-137%3A-Excluding-Insecure-Devices?node-id=105-44947&t=Rv1KWawqmg3tAYOk-4 shows the button text saying "Reset in progress..." Should the button here show the same thing?

@mxandreas
Copy link

shows the button text saying "Reset in progress..." Should the button here show the same thing?

Yes, I think the Figma was just updated and the snapshot here went out of date.

@richvdh richvdh self-assigned this Mar 3, 2025
@richvdh richvdh linked a pull request Mar 4, 2025 that will close this issue
4 tasks
@richvdh
Copy link
Member

richvdh commented Mar 4, 2025

I wondered if "Lock out UX" was a critical part of this, but Andreas says (and I agree):

I think the lock out UX was probably just an initial idea (when the ticket was created), but I do not think it is worth investing any time into it before there is evidence that this is necessary.

So, #29388 is enough to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants