Skip to content

New room list does not function well when all rooms are shown (large accounts) #14539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
turt2live opened this issue Jul 16, 2020 · 3 comments · Fixed by matrix-org/matrix-react-sdk#5048

Comments

@turt2live
Copy link
Member

#14035 (comment)

@jcgruenhage
Copy link

jcgruenhage commented Jul 16, 2020

I've switched to the new room list, my account is okay on my workstation (I didn't notice issues there), but it turned element on my Pinebook Pro from "okay" to "infuriatingly slow".

In the configuration I'd want to use ideally (all rooms, top 10 of other categories), it takes 8 seconds to switch a room, 2 seconds to even highlight it when hovering over it with the mouse. Composing messages is a pain to, since the composer lags between a few hundred ms to a few s behind what I'm actually typing. It's slowing down my laptop enough, that I actually closed element to submit this comment...

Even with everything reduced to top 5, the performance is bad, it takes 3.5s to switch rooms. With everything fully collapsed, it takes 1.5s, which is annoying, but bearable.

ftr, on account size: I have 916 visible rooms (so with old, upgraded rooms likely a few more in total).

@Ai-rin
Copy link

Ai-rin commented Jul 18, 2020

I experience composer lag too, after Riot became Element. Could it be due to new roomlist? I don't see a way to disable it now.

@turt2live turt2live self-assigned this Jul 20, 2020
@turt2live
Copy link
Member Author

image

Test case: 3000 rooms shown, receive an event

Looks like we might be sending too much to React to figure out. The room list only takes 4.22ms to figure out what it needs to look like, but then spends well over a second making that change happen (the screenshot shows ~779ms of this). This is likely because we're not scoping the list updates to a particular tag, and thus re-render the entire list. We probably do not need to be remounting everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants