Skip to content

on hitting 'show more' on the new room list, a11y can incorrectly mark the newly displayed room as having keyboard focus #14395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ara4n opened this issue Jul 9, 2020 · 6 comments · Fixed by matrix-org/matrix-react-sdk#4973
Closed

on hitting 'show more' on the new room list, a11y can incorrectly mark the newly displayed room as having keyboard focus #14395

ara4n opened this issue Jul 9, 2020 · 6 comments · Fixed by matrix-org/matrix-react-sdk#4973
Assignees
@t3chguy
Labels
A11y A-Room-List T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Jul 9, 2020

No description provided.

@turt2live
Copy link
Member

specifically if there's not enough rooms to warrant a 'show less' button (ie: 5 rooms)

@t3chguy
Copy link
Member

t3chguy commented Jul 11, 2020

a11y can incorrectly mark the newly displayed room as having keyboard focus

The a11y code should be putting the focus on the top-most new tile, the one which would be in a similar location to the Show more button, I am not following what is incorrect about this?

@t3chguy
Copy link
Member

t3chguy commented Jul 12, 2020

I believe this is caused by #14426

Where it causes it to put the focus one too far

@turt2live
Copy link
Member

Blocked by #14426 as it could very well fix it

@turt2live
Copy link
Member

Current theory is that matrix-org/matrix-react-sdk#4964 will fix this, though testing is required.

@t3chguy
Copy link
Member

t3chguy commented Jul 14, 2020

Regression caused by matrix-org/matrix-react-sdk@96f2968#diff-f90ab14c3901148afd3231b9329c95ccL221

@t3chguy t3chguy self-assigned this Jul 14, 2020
@t3chguy t3chguy mentioned this issue Jul 14, 2020
Merged
@jryans jryans added A11y and removed I18n labels Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A11y A-Room-List T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix show-all keyboard focus regression matrix-org/matrix-react-sdk
4 participants
@jryans @turt2live @ara4n @t3chguy