Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FInd more efficient way to check room memberships for appservices #468

Open
matrixbot opened this issue Oct 30, 2024 · 2 comments
Open

FInd more efficient way to check room memberships for appservices #468

matrixbot opened this issue Oct 30, 2024 · 2 comments
Labels
C-App-Services T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. X-Performance Issue/PR around something that is slow or taking lots of memory

Comments

@matrixbot
Copy link
Collaborator

This issue was originally created by @anoadragon453 at matrix-org/dendrite#468.

Currently app services will get events related to their namespace from any room on the homeserver, even if they are not part of that room yet. This isn't really intended behavior, and thus should be scoped to only the room the app service is a part of.

@matrixbot matrixbot added C-App-Services T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. X-Performance Issue/PR around something that is slow or taking lots of memory labels Oct 30, 2024
@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @Half-Shot at matrix-org/dendrite#468 (comment).

I don't believe this is still true, do you think @neilalexander ?

@matrixbot
Copy link
Collaborator Author

This comment was originally posted by @neilalexander at matrix-org/dendrite#468 (comment).

We now have this as of #1680 but the process isn't amazing so we'd like to find a better/faster way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-App-Services T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. X-Performance Issue/PR around something that is slow or taking lots of memory
Projects
None yet
Development

No branches or pull requests

1 participant