Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAR dumper #609

Closed
ErikPelli opened this issue Dec 30, 2024 · 3 comments · Fixed by #610
Closed

HAR dumper #609

ErikPelli opened this issue Dec 30, 2024 · 3 comments · Fixed by #610

Comments

@ErikPelli
Copy link
Collaborator

Port the HAR logger feature from abourget/goproxy to the ext/ package of this project.
This feature must be part of the external package and not do a mess with the core project.

@ErikPelli
Copy link
Collaborator Author

#268

CameronBadman added a commit to CameronBadman/goproxy that referenced this issue Dec 31, 2024
Port HAR logging from abourget/goproxy to ext package.
Closes elazarl#609
@CameronBadman
Copy link
Contributor

had a crack at the issue, my apologies for doing it without being assigned

@ErikPelli
Copy link
Collaborator Author

Okay thank you, I'll take a look when I can and let you know

@ErikPelli ErikPelli assigned ErikPelli and CameronBadman and unassigned ErikPelli Jan 9, 2025
ErikPelli added a commit that referenced this issue Jan 10, 2025
* ext/har: add HAR logger extension

Port HAR logging from abourget/goproxy to ext package.
Closes #609

* reverted to go.mod and go.sum files

* fixed code issues from pull request 610 other then testing and SaveToFile

* added tesify testing and added fruther logs to ParseRequest

* added testify dependancy

* modernised fillIpaddress func to work for ipv6 addresses

* refactored HAR exporting componant

* Removed SaveToFile, SaveToFile Tests, AppendEntry, AppendPage, Clear, and GetEntries methods

* removed currentCOunt and lastExport functions to and refactored associated functions

* refactored exportLoop to use a timer and interval, refactored logger to account for edge cases of timer set with no interval

* fixed export system to work better and be more readble, switched to fixed channel size for the go routine

* fixed a compilation issue in types and fixed the logger_tests to use the callback function and to no longer by flakey

* fixed issues from the pull request including readability issues in the exportLoop, test viability,and package fixing

* updated Interval test to use a larger export Interval

* added client.Do in testing

* removed uneeded spaces and fixed issues in testing from batching and mutex issues

* removed the entry copies on the ExportFunc and refactored threshold logger test to measure based on freq not a sorterd set

* ctx is always not nil

* Avoid to expose request and response parser functions

* Update logger.go

---------

Co-authored-by: Erik Pellizzon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants