Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove XML dependencies #2804

Open
valeriy42 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #2806
Open

Remove XML dependencies #2804

valeriy42 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #2806
Assignees
@edsavage
Labels
>refactoring

Comments

@valeriy42
Copy link
Contributor

The XML parser is used only for test data parsing, while the normal input and output rely exclusively on JSON. Removing XML readers from the code would allow us to remove dependencies on libXML and RapidXML and simplify several classes.
@edsavage edsavage self-assigned this Dec 27, 2024
edsavage added a commit to edsavage/ml-cpp that referenced this issue Jan 7, 2025
@edsavage
[ML] Remove use of XML serialisers in unit tests.
395df70 
Replacing the use of XML serialisers in unit tests with equivalent JSON serialisers allows the removal of dependencies on the 3rd party RapidXML library and also the bespoke XML parser and related code.

Closes elastic#2804
@edsavage edsavage linked a pull request Jan 7, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edsavage edsavage

Labels
>refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Remove use of XML serialisers in unit tests. edsavage/ml-cpp
2 participants
@valeriy42 @edsavage