Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adjust the behavior of skip_result custom rules #2553

Open
valeriy42 opened this issue Aug 11, 2023 · 2 comments
Open

[ML] Adjust the behavior of skip_result custom rules #2553

valeriy42 opened this issue Aug 11, 2023 · 2 comments
Assignees
Labels

Comments

@valeriy42
Copy link
Contributor

valeriy42 commented Aug 11, 2023

Currently, if we define skip_result it avoids updating distribution quantiles. This can change the impact on the anomaly score, although the anomaly probability remains the same.

Ideally, we need to change the behavior such that for skip_result, the algorithm behaves "normally", except it avoids writing records and changing aggregates.

\cc @tveasey

@valeriy42
Copy link
Contributor Author

Maybe we should introduce result.s_ShouldGetAnomaly or something like that similar to result.s_ShouldUpdateModel to control this behavior explicitly.

@valeriy42 valeriy42 added the :ml label Aug 11, 2023
@valeriy42 valeriy42 changed the title Adjust the behavior of skip_result custom rules [ML] Adjust the behavior of skip_result custom rules Aug 11, 2023
@valeriy42 valeriy42 self-assigned this Feb 6, 2024
@droberts195
Copy link
Contributor

I don't think we should introduce a third user-facing config option. Updating the model but not the quantiles just sounds wrong if the rule was set up to update the model but not write out any anomalies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants