Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Follow ups for in-table search #208939

Open
jughosta opened this issue Jan 30, 2025 · 1 comment
Open

[Discover] Follow ups for in-table search #208939

jughosta opened this issue Jan 30, 2025 · 1 comment
Assignees
@jughosta
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@jughosta
Copy link
Contributor

Originally suggested in #206454 (review)

  • When using the native Chrome find, I can hold down Enter to cycle through matches, while in ours I have to tap repeatedly. It might polish the UX a bit if we did the same.

  • When I was stepping through matches and encountered one that was truncated, I changed the row height, which triggered a new search and reset me back to 0. We might want to consider if it's possible to keep the user on their current match in this case.

  • When stepping through matches and reaching the last page, loading more results also triggered a new search and reset me back to 0. Another case where it may be helpful to track the current match, but this seems like it could be trickier.
@jughosta jughosta added enhancement New value added to drive a business result Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Jan 30, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

This was referenced Jan 30, 2025
Merged
Merged
jughosta added a commit that referenced this issue Feb 5, 2025
@jughosta
[Discover] Some cleanups for the new in-table search (#208980)
b1b28c3 
- Addresses #208939

## Summary

This PR makes some cleanups to the code introduced in
#206454 and adds more tests.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 5, 2025
@jughosta
[Discover] Some cleanups for the new in-table search (elastic#208980)
f0a2d06 
- Addresses elastic#208939

## Summary

This PR makes some cleanups to the code introduced in
elastic#206454 and adds more tests.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit b1b28c3)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 5, 2025
@jughosta
[Discover] Some cleanups for the new in-table search (elastic#208980)
84500f5 
- Addresses elastic#208939

## Summary

This PR makes some cleanups to the code introduced in
elastic#206454 and adds more tests.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit b1b28c3)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Feb 5, 2025
@jughosta
[Discover] Some cleanups for the new in-table search (elastic#208980)
65d41ec 
- Addresses elastic#208939

## Summary

This PR makes some cleanups to the code introduced in
elastic#206454 and adds more tests.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit b1b28c3)
drewdaemon pushed a commit to drewdaemon/kibana that referenced this issue Feb 6, 2025
@jughosta @drewdaemon
[Discover] Some cleanups for the new in-table search (elastic#208980)
549c285 
- Addresses elastic#208939

## Summary

This PR makes some cleanups to the code introduced in
elastic#206454 and adds more tests.


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jughosta @elasticmachine