Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SLM multiple policy restriction #101007

Open
nickofthyme opened this issue May 31, 2021 · 7 comments · May be fixed by #207748
Open

Remove SLM multiple policy restriction #101007

nickofthyme opened this issue May 31, 2021 · 7 comments · May be fixed by #207748
Assignees
@SoniaSanzV
Labels
bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@nickofthyme
Copy link
Contributor

nickofthyme commented May 31, 2021 •
edited
Loading

Kibana elasticsearch UI limits the number of concurrently scheduled snapshots in the code below...

image

kibana/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_list.tsx

Lines 156 to 175 in 0cf48f3

{hasDuplicateSchedules ? (
<Fragment>
<EuiCallOut
title={
<FormattedMessage
id="xpack.snapshotRestore.policyScheduleWarningTitle"
defaultMessage="Two or more policies have the same schedule"
/>
}
color="warning"
iconType="alert"
>
<FormattedMessage
id="xpack.snapshotRestore.policyScheduleWarningDescription"
defaultMessage="Only one snapshot can be taken at a time. To avoid snapshot failures, edit or delete the policies."
/>
</EuiCallOut>
<EuiSpacer />
</Fragment>
) : null}

However, per discussion on slack It appears that elasticsearch is capable of concurrent snapshots as of the next release 7.13.1, per elastic/elasticsearch#73456.

You can run multiple snapshots and snapshot deletes in parallel these days (in fact ever since 7.9). That said there have been a few hiccups with concurrent snapshot execution where rare bugs caused trouble. But upcoming 7.13.1 has no remaining known issues with it.

This should be tested to confirm no issues exist when removing aforementioned code.

Note: supported since [email protected] see elastic/elasticsearch#56911
@nickofthyme nickofthyme added Feature:elasticsearch Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.13.1 labels May 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@sebelga sebelga added Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI bug Fixes for quality problems that affect the customer experience and removed Feature:elasticsearch v7.13.1 labels May 31, 2021
@sebelga sebelga changed the title Remove iml multiple policy restriction Remove SLM multiple policy restriction May 31, 2021
@geekpete
Copy link
Member

You might still conditionally show a warning if the number of overlapping policies is greater than the configured concurrent snapshot setting value? snapshot.max_concurrent_operations

You can start multiple snapshot operations at the same time. Concurrent snapshot operations are limited by the snapshot.max_concurrent_operations cluster setting, which defaults to 1000. This limit applies in total to all ongoing snapshot creation, cloning, and deletion operations. Elasticsearch will reject any operations that would exceed this limit.
https://www.elastic.co/guide/en/elasticsearch/reference/current/snapshots-take-snapshot.html#create-snapshot-process-details

For example, if a user has set this to 1 then the warning would be pertinent rather than end up with a bunch of failing snapshots...possibly also non-deterministically failing if there's any race condition of which snapshot policy actually gets to run if snapshot policies have the same start time configured.

@leandrojmp
Copy link

Hello,

Is there any update about this issue? I'm on 8.5.1 and still get this message.

@nickofthyme
Copy link
Contributor Author

@elastic/platform-deployment-management

@alisonelizabeth
Copy link
Contributor

Is there any update about this issue? I'm on 8.5.1 and still get this message.

No updates on this issue yet. While I agree the message is confusing, it should not affect the snapshots themselves.

@leandrojmp
Copy link

Hello,

This still happens on 8.12.1

@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 16, 2024
@alisonelizabeth alisonelizabeth added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 16, 2024
@alisonelizabeth alisonelizabeth added good first issue low hanging fruit and removed bug Fixes for quality problems that affect the customer experience Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Sep 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 16, 2024
@alisonelizabeth alisonelizabeth added bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI and removed good first issue low hanging fruit needs-team Issues missing a team label labels Sep 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 16, 2024
@alisonelizabeth alisonelizabeth added the good first issue low hanging fruit label Sep 16, 2024
@alisonelizabeth alisonelizabeth added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 16, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 16, 2024
@SoniaSanzV SoniaSanzV linked a pull request Jan 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoniaSanzV SoniaSanzV

Labels
bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snapshot and restore]Remove SLM banner for duplicated shchedules SoniaSanzV/kibana
7 participants
@leandrojmp @geekpete @sebelga @alisonelizabeth @elasticmachine @nickofthyme @SoniaSanzV