Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-closing Github issues #55

Open
w33ble opened this issue Nov 30, 2015 · 5 comments
Open

Auto-closing Github issues #55

w33ble opened this issue Nov 30, 2015 · 5 comments

Comments

@w33ble
Copy link

w33ble commented Nov 30, 2015

Our pre-Jarvis workflow was to use the merge button on github, which would auto-close the issue based on the PR's description (using Closes/Fixes/Resolves #xxxx). In the post-Jarvis world, where we don't use the merge button, Github doesn't auto-close the issue for us.

I noticed after using Jarvis to merge and backport elastic/kibana#5509 that the issue it closed (here) was left open.

Is it possible to configure Jarvis to parse the PR's description the same way Github does internally and close the issue(s) that the PR relates to?

@ph
Copy link
Contributor

ph commented Nov 30, 2015

That shouldn't be an hard problem solve and it makes sense!

@w33ble
Copy link
Author

w33ble commented Nov 30, 2015

Note for parsing: sometimes we close multiple issues in a single PR, in which case the list of issues will be on a single line, comma delimited. For example:

Closes #123, #456 and #789

May or may not include the "and". The important bits are single line, starting with Closes/Fixes/Resolves and parsing all #xxx patterns on that line.

@spalger
Copy link

spalger commented Dec 1, 2015

This would be solved if #54 was implemented

@epixa
Copy link

epixa commented Dec 1, 2015

I think #54 is the way to go here. Let github do the work.

@w33ble
Copy link
Author

w33ble commented Dec 2, 2015

#54 ftw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants