Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The merge command should not work if the build is broken #31

Open
ph opened this issue May 28, 2015 · 1 comment
Open

The merge command should not work if the build is broken #31

ph opened this issue May 28, 2015 · 1 comment
Labels
enhancement

Comments

@ph
Copy link
Contributor

ph commented May 28, 2015

Currently the merge command doesnt check the status of the build before merging it to master, it would be nice if this command was aware of the jenkins build status. Maybe we can rely on the pull request status to get this information or use the jenkins api to detect it.

From time to time we had merged broken pull request in the master, thinking they were an easy fix.
@ph ph added the enhancement label May 28, 2015
@jordansissel
Copy link
Contributor

+1

@ph ph changed the title The merge command should not allow if the build is broken The merge command should not work if the build is broken Jun 2, 2015
@ph ph mentioned this issue Nov 24, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ph @jordansissel