Skip to content

[ES|QL] RERANK command - Prevent unnamed fields #126603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #124337
afoucret opened this issue Apr 10, 2025 · 2 comments
Closed
Tracked by #124337

[ES|QL] RERANK command - Prevent unnamed fields #126603

afoucret opened this issue Apr 10, 2025 · 2 comments
Assignees
@svilen-mihaylov-elastic
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@afoucret
Copy link
Contributor

afoucret commented Apr 10, 2025 •
edited
Loading

Acceptance criteria:

  • We should enforce the usage of an identifier for fields used in the RERANK command.

The following command:

FROM movies METADATA _score
  | WHERE QSTR("star wars")
  | RERANK "star wars" ON title, SUBSTRING(overview, 0, 100), actors WITH rerankerInferenceId

should fail because no name has been provided for the SUBSTRING expression.

The correct way to write it is:

FROM movies METADATA _score
  | WHERE QSTR("star wars")
  | RERANK "star wars" ON title, short_overview=SUBSTRING(overview, 0, 100), actors WITH rerankerInferenceId
@afoucret afoucret mentioned this issue Apr 10, 2025
Open
16 tasks
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Apr 10, 2025
@afoucret afoucret changed the title Prevent unnamed fields [ES|QL] RERANK command - Prevent unnamed fields Apr 10, 2025
@jbaiera jbaiera added the :Analytics/ES|QL AKA ESQL label Apr 14, 2025
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) and removed needs:triage Requires assignment of a team area label labels Apr 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Merged
@afoucret
Copy link
Contributor Author

#127416 is merged and does implement the check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svilen-mihaylov-elastic svilen-mihaylov-elastic

Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@afoucret @jbaiera @elasticsearchmachine @svilen-mihaylov-elastic