Skip to content

Commit 4950636

Browse files
authored
Fixing ComposableIndexTemplateTests (#130052)
1 parent 2a59bed commit 4950636

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

muted-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -563,9 +563,6 @@ tests:
563563
issue: https://github.com/elastic/elasticsearch/issues/130010
564564
- class: org.elasticsearch.xpack.esql.qa.mixed.MixedClusterEsqlSpecIT
565565
issue: https://github.com/elastic/elasticsearch/issues/128224
566-
- class: org.elasticsearch.cluster.metadata.ComposableIndexTemplateTests
567-
method: testMergeEmptyMappingsIntoTemplateWithNonEmptySettings
568-
issue: https://github.com/elastic/elasticsearch/issues/130050
569566
- class: org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT
570567
method: test
571568
issue: https://github.com/elastic/elasticsearch/issues/130067

server/src/test/java/org/elasticsearch/cluster/metadata/ComposableIndexTemplateTests.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,12 @@ public void testMergeEmptyMappingsIntoTemplateWithNonEmptySettings() throws IOEx
352352
// Attempting to merge in null mappings ought to fail
353353
ComposableIndexTemplate indexTemplate = randomInstance();
354354
expectThrows(NullPointerException.class, () -> indexTemplate.mergeMappings(null));
355-
assertThat(indexTemplate.mergeMappings(EMPTY_MAPPINGS), equalTo(indexTemplate));
355+
ComposableIndexTemplate mergedTemplate = indexTemplate.mergeMappings(EMPTY_MAPPINGS);
356+
if (indexTemplate.template() == null || indexTemplate.template().mappings() == null) {
357+
assertThat(mergedTemplate.template().mappings(), equalTo(EMPTY_MAPPINGS));
358+
} else {
359+
assertThat(mergedTemplate, equalTo(indexTemplate));
360+
}
356361
assertThat(indexTemplate.mergeSettings(Settings.EMPTY), equalTo(indexTemplate));
357362
}
358363

0 commit comments

Comments
 (0)