Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch-py 7.17 urllib3 version 2 support #2216

Open
buffer opened this issue May 5, 2023 · 3 comments
Open

elasticsearch-py 7.17 urllib3 version 2 support #2216

buffer opened this issue May 5, 2023 · 3 comments

Comments

@buffer
Copy link

buffer commented May 5, 2023

Hi,
I am required to still run ES 7 in my environment and so I have to rely on elasticsearch-py 7.17 for my Python stuff. While upgrading requests to the latest version I noticed a urllib3 dependency conflict. It seems like elasticsearch-py 7.17 pins urllib3 version to be < 2 while requests 2.30.0 would like to install urllib3 version 2. Do you think it 's possible to modify the setup.py file so to use urllib3 version 2?

The branch 7.17 setup.py file looks like

install_requires = [
    "urllib3>=1.21.1, <2",
    "certifi",
]

and it should be modified this way

install_requires = [
    "urllib3>=1.21.1, <3",
    "certifi",
]

Thanks!

@jgb
Copy link

jgb commented Jul 26, 2023

+1 this would be a useful change! It's blocking an upgrade of urllib3 for us as well.

@JoshMock
Copy link
Member

Related: elastic/elastic-transport-python#105

@pquentin
Copy link
Member

pquentin commented Nov 7, 2023

Hello, elasticsearch-py 8.x now supports urllib3 2.0, but I don't have immediate plans to support urllib3 2.0 on elasticsearch-py 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants