Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.8.x] ForceMerge renamed to Forcemerge #1131

Closed
kbond opened this issue Apr 23, 2021 · 6 comments
Closed

[6.8.x] ForceMerge renamed to Forcemerge #1131

kbond opened this issue Apr 23, 2021 · 6 comments
Labels
BC break
Milestone
6.8.2

Comments

@kbond
Copy link

kbond commented Apr 23, 2021 •
edited
Loading

Summary of problem or feature request

Elasticsearch\Endpoints\Indices\ForceMerge was renamed to Elasticsearch\Endpoints\Indices\Forcemerge here.

Reference: ruflin/Elastica#1947 (comment) & ruflin/Elastica#1948
@ezimuel
Copy link
Contributor

ezimuel commented May 14, 2021

Using the new code generator there were some naming issue. This happened because in the past the API endpoints has been created manually. I'll try to fix this issue with a new patch release 6.8.2 soon. I'm sorry for the inconvenient.

@ezimuel ezimuel added this to the 6.8.2 milestone May 14, 2021
@ezimuel ezimuel mentioned this issue May 14, 2021
Open
@kbond
Copy link
Author

kbond commented May 14, 2021

I'm sorry for the inconvenient.

No worries whatsoever! 🙂

@deguif
Copy link

deguif commented May 18, 2021

Thanks @ezimuel
I will wait for 6.8.2 and relaunch tests on the 6.x version of ruflin/elastica

@timonf
Copy link

timonf commented May 20, 2021

@ezimuel When can we expect 6.8.2?

@ezimuel ezimuel mentioned this issue Jul 5, 2021
Merged
@ezimuel
Copy link
Contributor

ezimuel commented Jul 6, 2021

@kbond, @deguif can you review the PR #1151 ? Thanks!

ezimuel added a commit that referenced this issue Jul 14, 2021
@ezimuel
Fixed #1131 using old endpoint naming (#1151)
469c08e 
* Fixed #1131 using old endpoint naming

* Removed phpcs for autogenerated files

* FIxed phpstan issue

* Fixed getAliases() in IndicesNamespace

* Updated endpoints with ES 6.8.16

* Set symplify/git-wrapper < 9.3.27
@ezimuel
Copy link
Contributor

ezimuel commented Jul 14, 2021

Just released v6.8.2 including #1151 fix.

@ezimuel ezimuel closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break
Projects
None yet
Milestone
6.8.2
Development

No branches or pull requests
4 participants
@kbond @ezimuel @timonf @deguif