Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release? #16

Open
DRoet opened this issue Sep 1, 2020 · 3 comments
Open

Release? #16

DRoet opened this issue Sep 1, 2020 · 3 comments
Assignees

Comments

@DRoet
Copy link
Contributor

DRoet commented Sep 1, 2020

The readme lists support for monolog v2 but the latest version on packagist (elastic/ecs-logging) is an older version (1.0.1) that is not synced up with the instructions in this repo.

Maybe release an alpha/beta so its less confusing? right now it's not clear you will have to pull the repo using "dev-master'

@TSchuermans
Copy link

I think you're mixing monolog up with psr/log

@DRoet
Copy link
Contributor Author

DRoet commented Oct 1, 2020

Apologies, I just realised the older 1.0.1 release does work with monolog v2. I was talking about the v2 namespace changes introduced in January, see commit b0e438a and 62f2b60 that changes how the library works.

If people follow the instructions in the readme it will not work with the older 1.0.1 version which can be confusing.

@SergeyKleyman
Copy link
Contributor

In the latest release (1.0.2) we decided to revert v2 namespace changes and stay with Monolog version neutral namespace for now - if it will be necessary it should be possible to add support for Monolog v1 by detecting Monolog version at runtime i.e., without requiring changes to the part of the application referring to ElasticCommonSchemaFormatter. As a bonus 1.0.2 is backward compatible with already existing 1.* releases (as it should be).
The online docs are in sync as well.

@SergeyKleyman SergeyKleyman self-assigned this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants