Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider using URL for parsing in helpers.formatHttpRequest #52

Open
trentm opened this issue Feb 8, 2021 · 0 comments
Open

consider using URL for parsing in helpers.formatHttpRequest #52

trentm opened this issue Feb 8, 2021 · 0 comments
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Feb 8, 2021

Currently formatHttpRequest is manually doing URL parsing. I think using the standard url.URL for parsing would fix potential issues with weird URLs.

Also, in the case of a hapi request object, there is an already parsed request.url available. Express request objects might have the same thing. Not sure about other frameworks (e.g. fastify).
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trentm