Skip to content

Commit 717a46e

Browse files
authored
chore(slack-lite): switch to pull_request_target so have access to repo secrets (#208)
No need for us to be running code from the PR itself, so this event is fine. Before this change, a workflow run for a PR from a *fork* would have 'Secret source: None' and hence not have access to the SLACK_BOT_TOKEN Also be clearer on the 'slack-lite' brand. Refs: elastic/apm-agent-nodejs#4501
1 parent 6a6cdc8 commit 717a46e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/slack.yml renamed to .github/workflows/slack-lite.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,19 @@
1111
# 3. Optionally tweak the `if:` and `on:` sections below to control which issue
1212
# and PR events are skipped.
1313

14-
name: slack
14+
name: slack-lite
1515

1616
env:
1717
SLACK_CHANNEL: "#apm-agent-node"
1818

1919
on:
2020
issues:
2121
types: [opened, reopened, closed]
22-
pull_request:
22+
pull_request_target:
2323
types: [opened, ready_for_review, reopened, closed]
2424

2525
jobs:
26-
slack:
26+
slack-lite:
2727
# Skip notification if:
2828
# - dependabot or renovate PRs, too noisy
2929
# - draft PRs

0 commit comments

Comments
 (0)