Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether client.ForceMetadataRefresh() is necessary #318

Open
marclop opened this issue Oct 31, 2023 · 2 comments
Open

Investigate whether client.ForceMetadataRefresh() is necessary #318

marclop opened this issue Oct 31, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@marclop
Copy link
Contributor

marclop commented Oct 31, 2023

When constructing the common Kafka client, a call to the ForceMetadataRefresh method is issued. It may not be necessary to do so, since the kgo.Client will issue a call to that method when it needs to.

apm-queue/kafka/common.go

Lines 294 to 295 in 8c6a813

// Issue a metadata refresh request on construction, so the broker list is populated.
client.ForceMetadataRefresh()

@marclop marclop added the enhancement New feature or request label Oct 31, 2023
@marclop marclop changed the title Investigate whether client. ForceMetadataRefresh() is necessary Investigate whether client.ForceMetadataRefresh() is necessary Oct 31, 2023
@simitt
Copy link
Contributor

simitt commented Nov 16, 2023

@marclop how expensive is this operation? Trying to get a sense of urgency for this.

@marclop
Copy link
Contributor Author

marclop commented Nov 16, 2023

It's not expensive, but it makes some unit tests flaky. I haven't yet seen this happen badly in the CI, so I think we can defer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants