Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands do not work + missing UI #249

Open
strnglp opened this issue May 27, 2023 · 12 comments
Open

Commands do not work + missing UI #249

strnglp opened this issue May 27, 2023 · 12 comments

Comments

@strnglp
Copy link

strnglp commented May 27, 2023

Running electron-22 branch from the tip or the last tagged release the client seems not quite in working order.

  1. ? icon isn't there in the bottom right
  2. : prefix commands do not work

I tried to build master but it fails downloading an older electron.
@ondreian
Copy link
Collaborator

Which : commands did you try?

@strnglp
Copy link
Author

strnglp commented May 30, 2023

All of them. I am using the electron-22 branch and I noticed :config and :theme doesn't appear in the code anymore? It used to be in a folder called vimish in the master branch. I had assumed you refactored significantly and haven't gotten around to reintroducing the concept.

Note I also tried the release zips and had the same result.

@strnglp
Copy link
Author

strnglp commented Jul 20, 2023

Is this still actively developed? Does it work for you?

@ondreian
Copy link
Collaborator

I am working on some things on my localhost, I use it as my daily driver for an FE, but I pruned a lot of stuff back because the scope had creeped a bit in several places.

@strnglp
Copy link
Author

strnglp commented Jul 21, 2023

Understood, if you do wind up pushing the changes up I'd be happy to test and attempt bug fixes. I think what you've built is great and gives players options. For instance I want to run this in linux and I don't know of any other options.

@ondreian
Copy link
Collaborator

ondreian commented Jul 21, 2023 via email

@litch
Copy link
Contributor

litch commented Oct 12, 2023

Gentle nudge on this thanks! Looks like a pretty intense project to be sure but something it may be fun to see more progress on.

@ondreian
Copy link
Collaborator

If you are using modern lich, it will autodetect the session and connect if active.

@litch
Copy link
Contributor

litch commented Oct 12, 2023

Right. Connects just fine, but the previously-documented :commands don't work, and none of the theme switching seems to work. I've been able to go in and monkey with some of the TS and CSS and have it looking & feeling nicer. I kind of got the impression that you did a bunch of work to bring it to compliance with electron-22, but wound up with a massive amount of cruft around, but the "happy path" of it generally works for you, which is cool.

@ondreian
Copy link
Collaborator

ondreian commented Oct 12, 2023 via email

@litch
Copy link
Contributor

litch commented Oct 13, 2023

Yes that makes sense. You mentioned using it as your daily driver, is that a branch that you've just got local that you're using actively? I did a fair amount of rework on the UI and it feels a lot nicer to me, but would be interested in actual feature work that may be interesting (more nimble highlights?)

@ondreian
Copy link
Collaborator

ondreian commented Oct 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@litch @ondreian @strnglp