Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not usable as global modifier when sheet is presented #68

Open
mkubista opened this issue Mar 29, 2023 · 7 comments
Open

Not usable as global modifier when sheet is presented #68

mkubista opened this issue Mar 29, 2023 · 7 comments

Comments

@mkubista
Copy link

I tried this in my project, where Im using some views in sheets. I need some global error handling, so I used this on top level view. It cant work, because this implementation uses simple overlay over content view. Unfortunately I didnt look into the source codes before trying to integrate it... 😞

@gshaw
Copy link

gshaw commented Apr 27, 2023

@mkubista thanks for the heads up. I too would like something to use for a global view. Did you find anything that does work?

@svenoaks
Copy link

You can use it inside a sheet, you just need to put the modifier inside the sheet too

@ImTheSquid
Copy link

My fork should fix your issue.

@rocketraman
Copy link

@ImTheSquid I would like this functionality but your fork gives me the error:

Type 'any View' cannot conform to 'View'

@ImTheSquid
Copy link

Can you give me a full compiler backtrace so I can see where that's happening? Also make sure you pull the repo again and tell me what version of Swift and iOS you're using.

@rocketraman
Copy link

Can you give me a full compiler backtrace so I can see where that's happening? Also make sure you pull the repo again and tell me what version of Swift and iOS you're using.

@ImTheSquid I definitely had the latest master. iOS 16.2, Xcode 14.2 (Swift 5.7 I think?). I don't know the compiler backtrace as I ended up switching back to elai950/AlertToast and just adding it to the sheet view as suggested by @svenoaks , and it worked.

@afern247
Copy link

any fix on this? The loading animation appears under the sheets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants