Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Split and Concat related PRs from Upstream #15

Open
3 tasks
iksnagreb opened this issue Jan 21, 2025 · 1 comment
Open
3 tasks

Integrate Split and Concat related PRs from Upstream #15

iksnagreb opened this issue Jan 21, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@iksnagreb
Copy link

Would be nice to integrate the following contributions related to support of split and concat operations, which are still not merged into the upstream FINN but required by some of my Transformer-related research, as well as upcoming improvements to streamlining and generalized activation function support:

In general, we should have a discussion on how/when to integrate PRs from the upstream repository: Do we simply PR across forks whenever we need/want something to be integrated here, or should we try to push the existing upstream PR forward (e.g. by adding a review) so we can get this the "usual way" synchronizing with Xilinx/dev?

@iksnagreb iksnagreb added the enhancement New feature or request label Jan 21, 2025
@iksnagreb iksnagreb self-assigned this Jan 21, 2025
@iksnagreb iksnagreb added help wanted Extra attention is needed question Further information is requested labels Jan 21, 2025
@LinusJungemann
Copy link
Member

In my opinion, we should do both. If we need something, just PR across forks and in addition add a review to the original PR. The review is done by us anyway, if we integrate it here and it helps the original PR getting integrated, but then we also do not need to wait months until something is in the original dev for us to integrate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants