From 8140a1c2c0c863f431f22b17310b309a8d1696ff Mon Sep 17 00:00:00 2001 From: Guy Luz Date: Sun, 9 Jun 2024 10:50:14 +0300 Subject: [PATCH] Small code improvements (without logic change) --- .../example/android/app/build.gradle | 2 +- .../example/lib/main.dart | 35 ++++++------------- .../melos_flutter_background_service.iml | 2 +- ...los_flutter_background_service_android.iml | 2 +- .../melos_flutter_background_service_ios.iml | 2 +- 5 files changed, 15 insertions(+), 28 deletions(-) diff --git a/packages/flutter_background_service/example/android/app/build.gradle b/packages/flutter_background_service/example/android/app/build.gradle index f4df65b1..82f5bbce 100644 --- a/packages/flutter_background_service/example/android/app/build.gradle +++ b/packages/flutter_background_service/example/android/app/build.gradle @@ -44,7 +44,7 @@ android { defaultConfig { // TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html). applicationId "id.flutter.example" - minSdkVersion 19 + minSdkVersion flutter.minSdkVersion targetSdkVersion flutter.targetSdkVersion versionCode flutterVersionCode.toInteger() versionName flutterVersionName diff --git a/packages/flutter_background_service/example/lib/main.dart b/packages/flutter_background_service/example/lib/main.dart index bf6421e7..a82c571b 100644 --- a/packages/flutter_background_service/example/lib/main.dart +++ b/packages/flutter_background_service/example/lib/main.dart @@ -154,9 +154,7 @@ void onStart(ServiceInstance service) async { if (Platform.isAndroid) { final androidInfo = await deviceInfo.androidInfo; device = androidInfo.model; - } - - if (Platform.isIOS) { + } else if (Platform.isIOS) { final iosInfo = await deviceInfo.iosInfo; device = iosInfo.model; } @@ -211,33 +209,26 @@ class _MyAppState extends State { ), ElevatedButton( child: const Text("Foreground Mode"), - onPressed: () { - FlutterBackgroundService().invoke("setAsForeground"); - }, + onPressed: () => + FlutterBackgroundService().invoke("setAsForeground"), ), ElevatedButton( child: const Text("Background Mode"), - onPressed: () { - FlutterBackgroundService().invoke("setAsBackground"); - }, + onPressed: () => + FlutterBackgroundService().invoke("setAsBackground"), ), ElevatedButton( child: Text(text), onPressed: () async { final service = FlutterBackgroundService(); var isRunning = await service.isRunning(); - if (isRunning) { - service.invoke("stopService"); - } else { - service.startService(); - } + isRunning + ? service.invoke("stopService") + : service.startService(); - if (!isRunning) { - text = 'Stop Service'; - } else { - text = 'Start Service'; - } - setState(() {}); + setState(() { + text = isRunning ? 'Start Service' : 'Stop Service'; + }); }, ), const Expanded( @@ -245,10 +236,6 @@ class _MyAppState extends State { ), ], ), - floatingActionButton: FloatingActionButton( - onPressed: () {}, - child: const Icon(Icons.play_arrow), - ), ), ); } diff --git a/packages/flutter_background_service/melos_flutter_background_service.iml b/packages/flutter_background_service/melos_flutter_background_service.iml index 9fc8ce79..87149cbb 100644 --- a/packages/flutter_background_service/melos_flutter_background_service.iml +++ b/packages/flutter_background_service/melos_flutter_background_service.iml @@ -26,4 +26,4 @@ - + \ No newline at end of file diff --git a/packages/flutter_background_service_android/melos_flutter_background_service_android.iml b/packages/flutter_background_service_android/melos_flutter_background_service_android.iml index 9fc8ce79..87149cbb 100644 --- a/packages/flutter_background_service_android/melos_flutter_background_service_android.iml +++ b/packages/flutter_background_service_android/melos_flutter_background_service_android.iml @@ -26,4 +26,4 @@ - + \ No newline at end of file diff --git a/packages/flutter_background_service_ios/melos_flutter_background_service_ios.iml b/packages/flutter_background_service_ios/melos_flutter_background_service_ios.iml index 9fc8ce79..87149cbb 100644 --- a/packages/flutter_background_service_ios/melos_flutter_background_service_ios.iml +++ b/packages/flutter_background_service_ios/melos_flutter_background_service_ios.iml @@ -26,4 +26,4 @@ - + \ No newline at end of file