Standardize makeWrapperArgs

[jonringer]

A lot of "buildX" helpers can wrap programs, we should standardize this so they can be used in more normalized ways.

[nrdxp]

are you talking specifically about the args passed to the make wrapper function, or the wrappers themselves?

[jonringer]

I guess I want makeWrapper/makeShellWrapper to respect makeWrapperArgs, so python's and gApps' wrappers don't really need to do anything special. Similarly, we could replace:

postInstall = ''
  wrapProgram $out/bin/foo \
    --prefix PATH : ${lib.getBin bar}/bin/bar \
    --set SOME_FLAG 1 \
'';

with:

postInstall = ''
  wrapProgram $out/bin/foo
'';
makeWrapperArgs = [
  "--prefix PATH : ${lib.getBin bar}/bin/bar"
  "-set SOME_FLAG 1"
];

[jonringer]

Similarly, if gappsWrapperArgs just appended values to makeWrapperArgs, then we wouldn't need:

  makeWrapperArgs+=("''${gappsWrapperArgs[@]}")

https://github.com/NixOS/nixpkgs/blob/3f1ae27cc56a7535a494dbd47ef97e4fb3102762/pkgs/games/gshogi/default.nix#L36