From 0662ea22b8c434a4cdf5ed2950c4e706ab08d17d Mon Sep 17 00:00:00 2001
From: Jan Luebbe <jlu@pengutronix.de>
Date: Thu, 28 Sep 2023 10:23:28 +0200
Subject: [PATCH] src/manifest: add missing return on error

Credit to OSS-Fuzz for finding this issue.

Fixes: 1e2d723f ("src/manifest: explicit error when using [handler] args without filename")
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
---
 src/manifest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/manifest.c b/src/manifest.c
index fe1cfbed0..b8b9804d6 100644
--- a/src/manifest.c
+++ b/src/manifest.c
@@ -250,6 +250,7 @@ static gboolean parse_manifest(GKeyFile *key_file, RaucManifest **manifest, GErr
 	if (raucm->handler_args && !raucm->handler_name) {
 		g_set_error(error, G_KEY_FILE_ERROR, G_KEY_FILE_ERROR_PARSE,
 				"Setting 'args' requires a full custom handler to be defined under 'filename' in group '[handler]'.");
+		return FALSE;
 	}
 	if (!check_remaining_keys(key_file, "handler", &ierror)) {
 		g_propagate_error(error, ierror);