Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rough edges to refactor #28

Open
4 tasks done
ejnnr opened this issue Feb 15, 2024 · 1 comment
Open
4 tasks done

Rough edges to refactor #28

ejnnr opened this issue Feb 15, 2024 · 1 comment

Comments

@ejnnr
Copy link
Owner

ejnnr commented Feb 15, 2024

Keeping track of things we probably want to fix at some point but that aren't priorities. I think we should fix these whenever we'd otherwise have to make the problem worse or write a bunch of code that a refactor would change.

  • The Debug config classes are pretty cumbersome. I'm leaning towards just getting rid of them entirely and letting automated tests manually configure things for fast runs.
  • Maybe configs shouldn't have Config in their name? It could be nice in order to avoid name clashes with e.g. the detector class itself, but from a user perspective, the Config classes are actually the more important ones so should maybe get a short name
  • Remove simple_parsing (by using something else to serialize/deserialize configs). We could also reconsider the whole hierarchical dataclass config systems (i.e. just instantiate detectors etc. directly, pass them to a script, and make detectors responsible for serializing their config)
  • Get rid of TaskConfigBase. It's not used anywhere and we now actually have some code that relies on the specifics of TaskConfig. So I think that should be the only ABC for tasks, and we should just generalize it if actually necessary in the future.
@ejnnr
Copy link
Owner Author

ejnnr commented Mar 3, 2024

  • I think it would probably be good to get rid of utils.inputs_from_batch() and handle this some other way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant