Not working in Chrome with multiple icons #85
Comments
|
The loop method might not work because of #86 |
|
The loop method now works once I install from master (see #87) |
|
Is that even recommended though? (Creating all those instances) |
|
Not the best solution but it works. I need to figure out how to do it directly in library so there will be only one instance... |
|
Yeah that would be good. |
|
It would help us with RocketChat/Rocket.Chat#348 |
|
@engelgabriel I will find a solution asap |
|
WOW! Thanks @ejci |
Open
|
I was hit by this as well when I tried to modify a confluence favicon. |
|
Hi @ejci I hope you are well... any ideas on this one? |
ubershmekel
added a commit
to ubershmekel/favico.js
that referenced
this issue
Jan 16, 2016
This fixes the chrome issue ejci#85
Merged
amatriain
added a commit
to amatriain/feedbunch
that referenced
this issue
Jan 26, 2016
Currently favico.js has a bug which only updates the last element with rel="icon" if there are several in the page head. This maeans that the favicon must be last in the head, particularly it must appear after the 192x192 icon (used in the mobile manifest). Related to this favico.js bug, might become unnecessary when it is fixed: ejci/favico.js#85
|
@adam-lynch Iterating over elements worked for me, see: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Nothing is happening.
I think it might be updating the wrong icon. I see that there's an
elementoption but specify the simple favicon doesn't work. If a different icon is actually in use by Chrome (surely not, right?), then I don't know which I should be specifying.So next I tried creating a favico instance for every
link[rel="icon"]I have and updating all of them in a loop. That didn't work either.#59 also doesn't help.
Any idea @ejci?
The text was updated successfully, but these errors were encountered: