fix: new lints coming with 1.78 and 1.80-nightly (#275)

* fix(doc): rename doc_cfg guard to docsrs, rust-lang/cargo#13875

* fix(node-wasm): remove unused method in JsContext trait

Author: zvolin

node-wasm/src/utils.rs

@@ -74,11 +74,6 @@ pub(crate) trait JsContext<T> {
     fn js_context<C>(self, context: C) -> Result<T, JsError>
     where
         C: fmt::Display + Send + Sync + 'static;
-
-    fn with_js_context<F, C>(self, context_fn: F) -> Result<T, JsError>
-    where
-        C: fmt::Display + Send + Sync + 'static,
-        F: FnOnce() -> C;
 }
 
 impl<T, E> JsContext<T> for std::result::Result<T, E>
@@ -91,15 +86,4 @@ where
     {
         self.map_err(|e| JsError::new(&format!("{context}: {e}")))
     }
-
-    fn with_js_context<F, C>(self, context_fn: F) -> Result<T, JsError>
-    where
-        C: fmt::Display + Send + Sync + 'static,
-        F: FnOnce() -> C,
-    {
-        self.map_err(|e| {
-            let context = context_fn();
-            JsError::new(&format!("{context}: {e}"))
-        })
-    }
 }

node/Cargo.toml

@@ -102,4 +102,4 @@ test-utils = ["celestia-types/test-utils"]
 
 [package.metadata.docs.rs]
 features = ["test-utils"]
-rustdoc-args = ["--cfg", "docs_rs"]
+rustdoc-args = ["--cfg", "docsrs"]

node/src/lib.rs

@@ -1,4 +1,4 @@
-#![cfg_attr(docs_rs, feature(doc_cfg))]
+#![cfg_attr(docsrs, feature(doc_cfg))]
 #![doc = include_str!("../README.md")]
 
 pub mod blockstore;
@@ -11,7 +11,7 @@ pub mod peer_tracker;
 pub mod store;
 pub mod syncer;
 #[cfg(any(test, feature = "test-utils"))]
-#[cfg_attr(docs_rs, doc(cfg(feature = "test-utils")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "test-utils")))]
 pub mod test_utils;
 mod utils;
 

rpc/Cargo.toml

@@ -54,4 +54,4 @@ wasm-bindgen = ["celestia-types/wasm-bindgen"]
 
 [package.metadata.docs.rs]
 features = ["p2p"]
-rustdoc-args = ["--cfg", "docs_rs"]
+rustdoc-args = ["--cfg", "docsrs"]

rpc/src/lib.rs

@@ -1,4 +1,4 @@
-#![cfg_attr(docs_rs, feature(doc_cfg))]
+#![cfg_attr(docsrs, feature(doc_cfg))]
 #![doc = include_str!("../README.md")]
 
 mod blob;
@@ -16,7 +16,7 @@ pub use crate::client::Client;
 pub use crate::error::{Error, Result};
 pub use crate::header::HeaderClient;
 #[cfg(feature = "p2p")]
-#[cfg_attr(docs_rs, doc(cfg(feature = "p2p")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "p2p")))]
 pub use crate::p2p::P2PClient;
 pub use crate::share::ShareClient;
 pub use crate::state::StateClient;

types/Cargo.toml

@@ -58,7 +58,7 @@ wasm-bindgen = ["celestia-tendermint/wasm-bindgen"]
 
 [package.metadata.docs.rs]
 features = ["p2p", "test-utils"]
-rustdoc-args = ["--cfg", "docs_rs"]
+rustdoc-args = ["--cfg", "docsrs"]
 
 [package.metadata.cargo-udeps.ignore]
 development = ["indoc"]

types/src/lib.rs

@@ -1,4 +1,4 @@
-#![cfg_attr(docs_rs, feature(doc_cfg))]
+#![cfg_attr(docsrs, feature(doc_cfg))]
 #![doc = include_str!("../README.md")]
 
 pub mod blob;
@@ -13,7 +13,7 @@ pub mod hash;
 pub mod namespaced_data;
 pub mod nmt;
 #[cfg(feature = "p2p")]
-#[cfg_attr(docs_rs, doc(cfg(feature = "p2p")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "p2p")))]
 pub mod p2p;
 pub mod row;
 mod rsmt2d;
@@ -22,7 +22,7 @@ mod share;
 pub mod state;
 mod sync;
 #[cfg(any(test, feature = "test-utils"))]
-#[cfg_attr(docs_rs, doc(cfg(feature = "test-utils")))]
+#[cfg_attr(docsrs, doc(cfg(feature = "test-utils")))]
 pub mod test_utils;
 pub mod trust_level;
 mod validate;