Skip to content

Commit 0be08cb

Browse files
tcskoabxvinosi-github
tcskoab
authored andcommitted
Event names in Eiffel2.0 should adhere to documentation of eiffel in Github. (#48)
1 parent 329494c commit 0be08cb

File tree

95 files changed

+251
-261
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

95 files changed

+251
-261
lines changed

build.gradle

+7-4
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ allprojects {
4848

4949
jar {
5050
baseName = 'eiffel-remrem-semantics'
51-
version = '0.2.6'
51+
version = '0.2.7'
5252
manifest {
5353
attributes('remremVersionKey': 'semanticsVersion')
5454
attributes('semanticsVersion': version)
@@ -64,7 +64,7 @@ jar {
6464

6565
shadowJar {
6666
baseName = 'eiffel-remrem-semantics'
67-
version = '0.2.6'
67+
version = '0.2.7'
6868
classifier = ''
6969
}
7070

@@ -139,8 +139,11 @@ task runJava(type:JavaExec){
139139
//please set 'runJava.enabled= true' to execute the :runJava task if needed only.
140140
runJava.enabled=false;
141141

142-
//To execute the task compileSourceCode first in gradle build.
143-
compileSourceCode.execute()
142+
/*To execute the task compileSourceCode first in gradle build when runJava.enabled=true
143+
144+
please uncomment this compileSourceCode.execute() when runJava method enabled(runJava.enabled=true)*/
145+
146+
//compileSourceCode.execute();
144147

145148
//To execute the runJava task before jsonSchema2pojo plugin execution .
146149
generateJsonSchema2Pojo.dependsOn runJava

src/main/java/com/ericsson/eiffel/remrem/semantics/EiffelEventType.java

+25-24
Original file line numberDiff line numberDiff line change
@@ -18,28 +18,28 @@
1818

1919

2020
public enum EiffelEventType {
21-
ARTIFACT_PUBLISHED("eiffelartifactpublished"),
22-
ACTIVITY_FINISHED("eiffelactivityfinished"),
23-
ACTIVITY_CANCELED("eiffelactivitycanceled"),
24-
ARTIFACT_CREATED("eiffelartifactcreated"),
25-
ACTIVITY_TRIGGERED("eiffelactivitytriggered"),
26-
CONFIDENCELEVEL_MODIFIED("eiffelconfidencelevelmodified"),
27-
ACTIVITY_STARTED("eiffelactivitystarted"),
28-
ANNOUNCEMENT_PUBLISHED("eiffelannouncementpublished"),
29-
COMPOSITION_DEFINED("eiffelcompositiondefined"),
30-
TESTCASE_CANCELED("eiffeltestcasecanceled"),
31-
TESTCASE_TRIGGERED("eiffeltestcasetriggered"),
32-
EXECUTION_RECIPE_COLLECTION_CREATED("eiffeltestexecutionrecipecollectioncreated"),
33-
ENVIRONMENT_DEFINED("eiffelenvironmentdefined"),
34-
FLOWCONTEXT_DEFINED("eiffelflowcontextdefined"),
35-
SOURCECHANGE_CREATED("eiffelsourcechangecreated"),
36-
SOURCECHANGE_SUBMITTED("eiffelsourcechangesubmitted"),
37-
TESTCASE_FINISHED("eiffeltestcasefinished"),
38-
TESTCASE_STARTED("eiffeltestcasestarted"),
39-
TESTSUITE_FINISHED("eiffeltestsuitefinished"),
40-
TESTSUITE_STARTED("eiffeltestsuitestarted"),
41-
ISSUE_VERIFIED("eiffelissueverified"),
42-
ARTIFACT_REUSED("eiffelartifactreused");
21+
ARTIFACT_PUBLISHED("EiffelArtifactPublishedEvent"),
22+
ACTIVITY_FINISHED("EiffelActivityFinishedEvent"),
23+
ACTIVITY_CANCELED("EiffelActivityCanceledEvent"),
24+
ARTIFACT_CREATED("EiffelArtifactCreatedEvent"),
25+
ACTIVITY_TRIGGERED("EiffelActivityTriggeredEvent"),
26+
CONFIDENCELEVEL_MODIFIED("EiffelConfidenceLevelModifiedEvent"),
27+
ACTIVITY_STARTED("EiffelActivityStartedEvent"),
28+
ANNOUNCEMENT_PUBLISHED("EiffelAnnouncementPublishedEvent"),
29+
COMPOSITION_DEFINED("EiffelCompositionDefinedEvent"),
30+
TESTCASE_CANCELED("EiffelTestCaseCanceledEvent"),
31+
TESTCASE_TRIGGERED("EiffelTestCaseTriggeredEvent"),
32+
EXECUTION_RECIPE_COLLECTION_CREATED("EiffelTestExecutionRecipeCollectionCreatedEvent"),
33+
ENVIRONMENT_DEFINED("EiffelEnvironmentDefinedEvent"),
34+
FLOWCONTEXT_DEFINED("EiffelFlowContextDefinedEvent"),
35+
SOURCECHANGE_CREATED("EiffelSourceChangeCreatedEvent"),
36+
SOURCECHANGE_SUBMITTED("EiffelSourceChangeSubmittedEvent"),
37+
TESTCASE_FINISHED("EiffelTestCaseFinishedEvent"),
38+
TESTCASE_STARTED("EiffelTestCaseStartedEvent"),
39+
TESTSUITE_FINISHED("EiffelTestSuiteFinishedEvent"),
40+
TESTSUITE_STARTED("EiffelTestSuiteStartedEvent"),
41+
ISSUE_VERIFIED("EiffelIssueVerifiedEvent"),
42+
ARTIFACT_REUSED("EiffelArtifactReusedEvent");
4343

4444
private String eventType;
4545

@@ -51,15 +51,16 @@ public enum EiffelEventType {
5151

5252
/**
5353
* This method used to get EiffelEventType Enum constant based on event type
54+
* Supports eventType, if we passed as lower case from cli and service and also check eventType is valid or not
5455
* @param eventType of an eiffel event
5556
* @return Enum constant of EiffelEventType
5657
*/
5758
public static EiffelEventType fromString(String eventType) {
5859
if (eventTypeMap.size() == 0) {
5960
for (EiffelEventType type : values())
60-
eventTypeMap.put(type.eventType, type);
61+
eventTypeMap.put(type.eventType.toLowerCase(), type);
6162
}
62-
return eventTypeMap.get(eventType);
63+
return eventTypeMap.get(eventType.toLowerCase().replace("event", "") + "event");
6364
}
6465

6566
/**

src/main/java/com/ericsson/eiffel/remrem/semantics/RoutingKeyTypes.java

+20-21
Original file line numberDiff line numberDiff line change
@@ -18,27 +18,26 @@
1818

1919
public enum RoutingKeyTypes {
2020

21-
eiffelactivitycanceled(EiffelConstants.ACTIVITY, "canceled"),
22-
eiffelactivityfinished(EiffelConstants.ACTIVITY,"finished"),
23-
eiffelactivitystarted(EiffelConstants.ACTIVITY,"started"),
24-
eiffelactivitytriggered(EiffelConstants.ACTIVITY,"triggered"),
25-
eiffelannouncementpublished(EiffelConstants.INFO,"announcement"),
26-
eiffelartifactcreated(EiffelConstants.ARTIFACT,"created"),
27-
eiffelartifactpublished(EiffelConstants.ARTIFACT,"published"),
28-
eiffelartifactreused(EiffelConstants.ARTIFACT,"reused"),
29-
eiffelcompositiondefined(EiffelConstants.CM,"composition"),
30-
eiffelconfidencelevelmodified(EiffelConstants.ARTIFACT,"modified"),
31-
eiffelconfigurationapplied(EiffelConstants.CONFIGURATION,"applied"),
32-
eiffelenvironmentdefined(EiffelConstants.CM,"environment"),
33-
eiffelflowcontextdefined(EiffelConstants.FLOWCONTEXT,"defined"),
34-
eiffelissueverified(EiffelConstants.TEST,"issueverified"),
35-
eiffelsourcechangecreated(EiffelConstants.CM,"scmchange"),
36-
eiffelsourcechangesubmitted(EiffelConstants.CM,"scmproposedchange"),
37-
eiffeltestcasefinished(EiffelConstants.TEST,"casefinished"),
38-
eiffeltestcasestarted(EiffelConstants.TEST,"casestarted"),
39-
eiffeltestsuitefinished(EiffelConstants.TEST,"suitefinished"),
40-
eiffeltestsuitestarted(EiffelConstants.TEST,"suitestarted"),
41-
eiffeltestexecutionrecipecollectioncreated(EiffelConstants.TEST,"execution");
21+
EiffelActivityCanceledEvent(EiffelConstants.ACTIVITY, "canceled"),
22+
EiffelActivityFinishedEvent(EiffelConstants.ACTIVITY,"finished"),
23+
EiffelActivityStartedEvent(EiffelConstants.ACTIVITY,"started"),
24+
EiffelActivityTriggeredEvent(EiffelConstants.ACTIVITY,"triggered"),
25+
EiffelAnnouncementPublishedEvent(EiffelConstants.INFO,"announcement"),
26+
EiffelArtifactCreatedEvent(EiffelConstants.ARTIFACT,"created"),
27+
EiffelArtifactPublishedEvent(EiffelConstants.ARTIFACT,"published"),
28+
EiffelArtifactReusedEvent(EiffelConstants.ARTIFACT,"reused"),
29+
EiffelCompositionDefinedEvent(EiffelConstants.CM,"composition"),
30+
EiffelConfidenceLevelModifiedEvent(EiffelConstants.ARTIFACT,"modified"),
31+
EiffelEnvironmentDefinedEvent(EiffelConstants.CM,"environment"),
32+
EiffelFlowContextDefinedEvent(EiffelConstants.FLOWCONTEXT,"defined"),
33+
EiffelIssueVerifiedEvent(EiffelConstants.TEST,"issueverified"),
34+
EiffelSourceChangeCreatedEvent(EiffelConstants.CM,"scmchange"),
35+
EiffelSourceChangeSubmittedEvent(EiffelConstants.CM,"scmproposedchange"),
36+
EiffelTestCaseFinishedEvent(EiffelConstants.TEST,"casefinished"),
37+
EiffelTestCaseStartedEvent(EiffelConstants.TEST,"casestarted"),
38+
EiffelTestSuiteFinishedEvent(EiffelConstants.TEST,"suitefinished"),
39+
EiffelTestSuiteStartedEvent(EiffelConstants.TEST,"suitestarted"),
40+
EiffelTestExecutionRecipeCollectionCreatedEvent(EiffelConstants.TEST,"execution");
4241

4342
private final String family; // family
4443
private final String type; // type

src/main/java/com/ericsson/eiffel/remrem/semantics/schemas/SchemaFile.java

-10
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public class SchemaFile {
4343
private JsonParser parser = new JsonParser();
4444
private boolean isEvent;
4545
private boolean isMeta = false;
46-
private boolean isEnumType = false;
4746
private String eventName = null;
4847

4948
/**
@@ -100,7 +99,6 @@ private void addAttributesToJsonSchema(JsonObject jsonContent, String jsonElemen
10099
isMeta = true;
101100
}
102101
if (name.equals(EiffelConstants.TYPE) && isMeta) {
103-
isEnumType = true;
104102
isMeta = false;
105103
}
106104
addingItemsProperties(name, valueSet.getValue(), jsonObject, previousObjectName);
@@ -146,14 +144,6 @@ private void addAttributesToJsonSchema(JsonObject jsonContent, String jsonElemen
146144
}
147145
} else {
148146
jsonObject.add(valueSet.getKey(), valueSet.getValue());
149-
if (valueSet.getKey().equals(EiffelConstants.ENUM)) {
150-
if (isEnumType) {
151-
// To change the eventType in meta
152-
jsonObject.add(valueSet.getKey(),
153-
parser.parse(valueSet.getValue().toString().toLowerCase().replace("event", "")));
154-
isEnumType = false;
155-
}
156-
}
157147
}
158148
}
159149
}

src/main/java/com/ericsson/eiffel/semantics/events/EiffelActivityCanceledEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelactivitycanceled")
168-
EIFFELACTIVITYCANCELED("eiffelactivitycanceled");
167+
@SerializedName("EiffelActivityCanceledEvent")
168+
EIFFEL_ACTIVITY_CANCELED_EVENT("EiffelActivityCanceledEvent");
169169
private final String value;
170170
private final static Map<String, EiffelActivityCanceledEventMeta.Type> CONSTANTS = new HashMap<String, EiffelActivityCanceledEventMeta.Type>();
171171

src/main/java/com/ericsson/eiffel/semantics/events/EiffelActivityFinishedEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelactivityfinished")
168-
EIFFELACTIVITYFINISHED("eiffelactivityfinished");
167+
@SerializedName("EiffelActivityFinishedEvent")
168+
EIFFEL_ACTIVITY_FINISHED_EVENT("EiffelActivityFinishedEvent");
169169
private final String value;
170170
private final static Map<String, EiffelActivityFinishedEventMeta.Type> CONSTANTS = new HashMap<String, EiffelActivityFinishedEventMeta.Type>();
171171

src/main/java/com/ericsson/eiffel/semantics/events/EiffelActivityStartedEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelactivitystarted")
168-
EIFFELACTIVITYSTARTED("eiffelactivitystarted");
167+
@SerializedName("EiffelActivityStartedEvent")
168+
EIFFEL_ACTIVITY_STARTED_EVENT("EiffelActivityStartedEvent");
169169
private final String value;
170170
private final static Map<String, EiffelActivityStartedEventMeta.Type> CONSTANTS = new HashMap<String, EiffelActivityStartedEventMeta.Type>();
171171

src/main/java/com/ericsson/eiffel/semantics/events/EiffelActivityTriggeredEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelactivitytriggered")
168-
EIFFELACTIVITYTRIGGERED("eiffelactivitytriggered");
167+
@SerializedName("EiffelActivityTriggeredEvent")
168+
EIFFEL_ACTIVITY_TRIGGERED_EVENT("EiffelActivityTriggeredEvent");
169169
private final String value;
170170
private final static Map<String, EiffelActivityTriggeredEventMeta.Type> CONSTANTS = new HashMap<String, EiffelActivityTriggeredEventMeta.Type>();
171171

src/main/java/com/ericsson/eiffel/semantics/events/EiffelAnnouncementPublishedEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelannouncementpublished")
168-
EIFFELANNOUNCEMENTPUBLISHED("eiffelannouncementpublished");
167+
@SerializedName("EiffelAnnouncementPublishedEvent")
168+
EIFFEL_ANNOUNCEMENT_PUBLISHED_EVENT("EiffelAnnouncementPublishedEvent");
169169
private final String value;
170170
private final static Map<String, EiffelAnnouncementPublishedEventMeta.Type> CONSTANTS = new HashMap<String, EiffelAnnouncementPublishedEventMeta.Type>();
171171

src/main/java/com/ericsson/eiffel/semantics/events/EiffelArtifactCreatedEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelartifactcreated")
168-
EIFFELARTIFACTCREATED("eiffelartifactcreated");
167+
@SerializedName("EiffelArtifactCreatedEvent")
168+
EIFFEL_ARTIFACT_CREATED_EVENT("EiffelArtifactCreatedEvent");
169169
private final String value;
170170
private final static Map<String, EiffelArtifactCreatedEventMeta.Type> CONSTANTS = new HashMap<String, EiffelArtifactCreatedEventMeta.Type>();
171171

src/main/java/com/ericsson/eiffel/semantics/events/EiffelArtifactPublishedEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelartifactpublished")
168-
EIFFELARTIFACTPUBLISHED("eiffelartifactpublished");
167+
@SerializedName("EiffelArtifactPublishedEvent")
168+
EIFFEL_ARTIFACT_PUBLISHED_EVENT("EiffelArtifactPublishedEvent");
169169
private final String value;
170170
private final static Map<String, EiffelArtifactPublishedEventMeta.Type> CONSTANTS = new HashMap<String, EiffelArtifactPublishedEventMeta.Type>();
171171

src/main/java/com/ericsson/eiffel/semantics/events/EiffelArtifactReusedEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelartifactreused")
168-
EIFFELARTIFACTREUSED("eiffelartifactreused");
167+
@SerializedName("EiffelArtifactReusedEvent")
168+
EIFFEL_ARTIFACT_REUSED_EVENT("EiffelArtifactReusedEvent");
169169
private final String value;
170170
private final static Map<String, EiffelArtifactReusedEventMeta.Type> CONSTANTS = new HashMap<String, EiffelArtifactReusedEventMeta.Type>();
171171

src/main/java/com/ericsson/eiffel/semantics/events/EiffelCompositionDefinedEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelcompositiondefined")
168-
EIFFELCOMPOSITIONDEFINED("eiffelcompositiondefined");
167+
@SerializedName("EiffelCompositionDefinedEvent")
168+
EIFFEL_COMPOSITION_DEFINED_EVENT("EiffelCompositionDefinedEvent");
169169
private final String value;
170170
private final static Map<String, EiffelCompositionDefinedEventMeta.Type> CONSTANTS = new HashMap<String, EiffelCompositionDefinedEventMeta.Type>();
171171

src/main/java/com/ericsson/eiffel/semantics/events/EiffelConfidenceLevelModifiedEventMeta.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Licensed under the Apache License, Version 2.0 (the "License");
55
you may not use this file except in compliance with the License.
66
You may obtain a copy of the License at
7-
7+
88
http://www.apache.org/licenses/LICENSE-2.0
99
Unless required by applicable law or agreed to in writing, software
1010
distributed under the License is distributed on an "AS IS" BASIS,
@@ -164,8 +164,8 @@ public void setSecurity(Security security) {
164164

165165
public enum Type {
166166

167-
@SerializedName("eiffelconfidencelevelmodified")
168-
EIFFELCONFIDENCELEVELMODIFIED("eiffelconfidencelevelmodified");
167+
@SerializedName("EiffelConfidenceLevelModifiedEvent")
168+
EIFFEL_CONFIDENCE_LEVEL_MODIFIED_EVENT("EiffelConfidenceLevelModifiedEvent");
169169
private final String value;
170170
private final static Map<String, EiffelConfidenceLevelModifiedEventMeta.Type> CONSTANTS = new HashMap<String, EiffelConfidenceLevelModifiedEventMeta.Type>();
171171

0 commit comments

Comments
 (0)