Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ReconstructedChargedParticles a subset collection of ReconstructedParticles #1571

Open
simonge opened this issue Aug 16, 2024 · 0 comments

Comments

@simonge
Copy link
Contributor

simonge commented Aug 16, 2024

Is your feature request related to a problem? Please describe.
At the moment Low-Q2 tagger events are added to the CombinedTracks collection in tracking.cc, these are then unnecessarily passed through the PID algorithms and cluster matching I would like to be able to add them directly to the ReconstructedParticles collection at the end. This will make the code more efficient and allow PID to be approached differently (mostly just set to electrons). The Far-Forward detectors would also be better placed to use this separate pathway.

The one place the FF(/FB) tracks provide information required earlier in the tracking is in vertexing and t0

Describe the solution you'd like
Anything at the moment called a ReconstructedCharged***Particle could be renamed e.g. ReconstructedTracker***Particle to better reflect the status of the collection in the reconstruction chain. Collections of particles from the FF/FB detectors which can take a different reconstruction pathway and acquire their PID can the be added together in the ReconstructedParticles collection. Subset collections can then be made from the full ReconstructedParticles collection to reproduce the charged/neutral/other subset collections.

The consumption of ReconstructedChargedParticles in the current setup would not need to be changed.

It may be better if ReconstructedParticles itself was not a subset collection for easier follow on analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant