-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow swap cursor to easily spot differences #60
Comments
Thank you for ypur feedback. Good idea. The plugin is built very simple. It just uses the image-editor in the middle. This is an intellij-component. I am thinking about your idea.
|
Here are two example image, probably it's easier in this case to identify the change but playing with a swipe after going back and forth you can spot it I've tried using the original background, but sometimes the background is too confusing due to a lot of other geometries around
I've seen similar tools having the option to quickly spot the differences making the difference blinking on the screen, using a high contrast color (https://github.com/yahoo/blink-diff, https://medium.com/loftbr/visual-regression-testing-eb74050f3366) or just marking them with a circle around them (I remember one diff tool but can't find it anymore) The button can be useful but depends if you can group nearby pixels into one unique diff area to avoid having to click a hundred times to find all the pixels |
First approach I try to create an animiated gif which "blinks" at the difference spots. I am curious how this will look like :-) Some code for showing animated gif can be stolen from https://github.com/howyi/intellij-motivational-gif/blob/master/src/MotivateAction.java |
Hi @ehmkah first thank you for the efforts on that. |
Yep definitely, I think this is can be very helpful and less distracting then the other version. |
I am playing a little bit and will release it soon as experimentel feature because a lot of things are really uggly |
i release version 1.9.0 of the plugin. It will be available during the next days - Waiting for your feedback. @grigala - Thanks for your support implementing this feature :-) |
Nice to see it go live! Thanks for the credit. I'm glad if I helped, and I'm excited to work on it further during the next Hackergarten event maybe... 🤙 |
Is your feature request related to a problem? Please describe.
When having to deal with very small differences between images, is difficult to easily spot them when using the white background.
In my case for example I'm tracking differences in charts where circles are drawn with a slightly different technique or with a slightly different radius. The actual difference is just a few bytes but its interesting can be hardly visible on the current implementation.
Describe the solution you'd like
As provided by the rich diff in GitHub, a swipe function to swipe between the two overlapping images can be very helpful to spot such differences easily and compare the two images.
Describe alternatives you've considered
An alternative is to increase the contrast or at least make configurable the diff color used on the "white background" view. This can increase the contrast with the background and easing the visibility of differences
Additional context
![Screenshot 2021-01-29 at 10 07 50](https://user-images.githubusercontent.com/1421091/106255130-e7f17e80-6219-11eb-9c4e-010908efd222.png)
One example of differences that are barely visible
This is anyway already a great and very useful plugin! Thank you
The text was updated successfully, but these errors were encountered: