Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Typing Comment #128

Open
linear bot opened this issue Jun 18, 2024 · 1 comment
Open

PR Typing Comment #128

linear bot opened this issue Jun 18, 2024 · 1 comment

Comments

@linear
Copy link

linear bot commented Jun 18, 2024

text.inputEl.type = "number";

eharris128 Jun 17, 2024

Moving "number" to a const and referencing that const is a minor follow up improvement.

eharris128 Jun 17, 2024

(ideally the const lives in the types directory?) Or whatever is best practice in Typescript. I am new with TS.

r-mahoney Jun 17, 2024

This i wasn't sure about this since its just an HTML input type like "email" or "password." Pretty much all my TS knowledge comes from googling on this project.

We can definitely go that way if you think it makes more sense

opening an issue for this comment here @echarris if you want to chat about it

@jsmorabito
Copy link
Collaborator

@eharris128 @r-mahoney this ticket was made 6+ months ago is it still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant