Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

egg-healthy launch failed with a TypeError #3355

Closed
zitudu opened this issue Dec 29, 2018 · 5 comments
Closed

egg-healthy launch failed with a TypeError #3355

zitudu opened this issue Dec 29, 2018 · 5 comments

Comments

@zitudu
Copy link

zitudu commented Dec 29, 2018

Egg-core failed to launch when egg-healthy plugin had been enabled and threw an TypeError: Class constructor Lifecycle cannot be invoked without 'new'.

Command line: egg-bin dev

egg-healthy: 1.0.0
egg: 2.8.1
egg-core: 4.7.1
egg-bin: 4.7..0

@zitudu zitudu changed the title egg-healthy launch failed with TypeError egg-healthy launch failed with a TypeError Dec 29, 2018
@atian25
Copy link
Member

atian25 commented Dec 29, 2018

hey, please retry after reinstall dependencies and please never lock it.

$ # reinstall deps and never lock it.
$ rm -rf node_modules yarn.lock package-lock.json
$ npm i --no-package-lock

@zitudu
Copy link
Author

zitudu commented Dec 29, 2018

I'd like to do as you suggested if I am not developing a framework that has been used in several different project on production and I have to take account of the problem of using different version may cause.

If any plan of egg-healthy to supporting egg of version 2.8.x (or egg-core v4.7.x)?

@atian25
Copy link
Member

atian25 commented Dec 29, 2018

we use semver, so yes it support.

could you provide a mini project for use to reproduce it

@egg-bot
Copy link

egg-bot commented Dec 29, 2018

Hello @zitudu. Please provide a reproducible example following the instruction.

Issues labeled by Need Reproduce will be closed if no activities in 7 days.


@zitudu,请根据这个说明提供最小可复现代码。

如果在 7 天内没有进展会被自动关闭。

@zitudu
Copy link
Author

zitudu commented Dec 30, 2018

I just cannot reproduce this error in a project initialized with npx egg-init --type=simple without the original yarn.lock file.

Since the yarn.lock file in the framework will be ignored for top apps, it seems no longer a problem as long as top apps installed egg correctly.

@zitudu zitudu closed this as completed Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants