Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

epaxos.go doesn't correctly check for fast quorum on fast path #10

Open
jiaochangyang opened this issue Nov 7, 2017 · 1 comment
Open

Comments

@jiaochangyang
Copy link

A colleague and I have been digging into this code base, and it looks like there's only a relaxed majority requirement in the fast path code, rather than the stricter quorum sizes in the TLA+ and paper.

//can we commit on the fast path?

and
//can we commit on the fast path?

both simply check that >N/2

Is there some detail we are overlooking?

Thanks

@nibeshrestha
Copy link

nibeshrestha commented Sep 7, 2018

There is a constant "DS" which has value 5. "DS" is being used to instantiate the no. of "deps" an instance has. So I believe, this code works for a system with at most 5 replicas. For 3 replica and 5 replica system, the size of fast quorum and slow quorum is same according to EPaxos spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants