Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Avoid the usage of sudo #67

Open
MoisesGSalas opened this issue Mar 9, 2023 · 3 comments
Open

[FEAT] Avoid the usage of sudo #67

MoisesGSalas opened this issue Mar 9, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@MoisesGSalas
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently tvm adds the tutor command to your PATH by symlinking the tutor_switcher script to /usr/local/bin/tutor. This requires sudo permissions, which seems excessive, and the global tutor can cause confusion when using tutor in a virtualenv outside of tvm. I would prefer, If I were to install tvm on a virtualenv, to limit the tvm managed tutor command to the scope of that virtualenv.

Describe the solution you'd like
I think we can use the script option from setup.py to create a tutor-shim that calls the tutor switcher (essentially a shell script). This script will be added to the PATH automatically when installing the package and should fill the same role.

Describe alternatives you've considered
None

Additional context
I have not tested this, but I think it could work.

@MoisesGSalas MoisesGSalas added the enhancement New feature or request label Mar 9, 2023
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Mar 10, 2023

We'll look into this in our next sprint (starting approximately a week and a half from now). Thanks for the report!

@Alec4r
Copy link
Member

Alec4r commented May 10, 2023

Hi @MoisesGSalas We have been thinking about this, and we are planning to move the symlink to userhome/.local/share/tutor instead of /usr/local/bin/tutor, maybe that could help us to avoid the usage of sudo.

Also I remind you that we don'r recommend install tvm in a virtualenv.

We hope have good news soon.

@Asespinel
Copy link

@santiagosuarezedunext I think we should put this again in our radar since it seems like a ggod request. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants