Add Forum v2 request logging #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taimoor-ahmed-1
commented
Jul 29, 2024
•
taimoor-ahmed-1
commented
- Send request to forum v2 alongside v1
- Validate both responses and log info in case of diff
- Issue Implement a mechanism in edx-platform to duplicate GET requests and send them both to v1 and v2 openedx/forum#4
taimoor-ahmed-1
force-pushed
the
feat/add_forum_v2_request_logging
branch
2 times, most recently
from
a268a18
to
1a95b90
Compare
send request to forum v2 alongside v1 validate both responses and log info in case of diff
taimoor-ahmed-1
force-pushed
the
feat/add_forum_v2_request_logging
branch
from
1a95b90
to
1fff44e
Compare
- compare json objects instead of response objects - format the added lines of code
Faraz32123
force-pushed
the
feat/add_forum_v2_request_logging
branch
from
7581470
to
afe87f8
Compare
Faraz32123
approved these changes
Aug 1, 2024
|
One Unit test is failing due to our change in code as it tries to access our url, and it fails. merging this PR for as we might change the code again. |
Faraz32123
pushed a commit
that referenced
this pull request
Sep 16, 2024
* feat: Add Forum v2 request logging send request to forum v2 alongside v1 validate both responses and log info in case of diff * feat: modify comparison and formatting - compare json objects instead of response objects - format the added lines of code --------- Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Muhammad Faraz Maqsood <[email protected]>
Faraz32123
pushed a commit
that referenced
this pull request
Sep 16, 2024
* feat: Add Forum v2 request logging send request to forum v2 alongside v1 validate both responses and log info in case of diff * feat: modify comparison and formatting - compare json objects instead of response objects - format the added lines of code --------- Co-authored-by: Taimoor Ahmed <[email protected]> Co-authored-by: Muhammad Faraz Maqsood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.