From 361a8ab62ea43639820789c54d6479d41f0eb518 Mon Sep 17 00:00:00 2001 From: Muhammad Faraz Maqsood Date: Wed, 28 Feb 2024 16:24:43 +0500 Subject: [PATCH] filter all block completions instead of only verticals --- openedx/features/sdaia_features/course_progress/signals.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/openedx/features/sdaia_features/course_progress/signals.py b/openedx/features/sdaia_features/course_progress/signals.py index a823b8f79ad7..783212957b00 100644 --- a/openedx/features/sdaia_features/course_progress/signals.py +++ b/openedx/features/sdaia_features/course_progress/signals.py @@ -30,12 +30,6 @@ def evaluate_subsection_completion_milestones(**kwargs): course_key = instance.context_key - p_unit = modulestore().get_item(instance.block_key).parent - c_units = modulestore().get_item(p_unit).children - completed_units = BlockCompletion.objects.filter(block_key__in=c_units, completion=1.0).count() - if not(completed_units == len(c_units)): - return - course = modulestore().get_course(course_key) course_completion_percentages_for_emails = course.course_completion_percentages_for_emails if not course.allow_course_completion_emails or not course_completion_percentages_for_emails: