Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not work #378

Open
1 of 3 tasks
or9 opened this issue Dec 22, 2024 · 0 comments
Open
1 of 3 tasks

Plugin does not work #378

or9 opened this issue Dec 22, 2024 · 0 comments

Comments

@or9
Copy link

or9 commented Dec 22, 2024

Please fill-in this template.

  • I have a question that is specific to this extension; thus, inappropriate for the main EditorConfig issue tracker.
  • I tried running code --disable-extensions and the issue did NOT present itself.

Delete the following condition if it doesn't apply to your case:

If the extension is not picking up the expected configuration for a file:

  • I tried npm install editorconfig -g and ran editorconfig [file-in-question] and the configuration was what I expected. If not, please file on the editorconfig-core-js issue tracker.

Issue

Visual Studio Code editorconfig-vscode
Version 1.96.0 v0.16.4

Root .editorconfig File

root = true

[*]
indent_style = tab
indent_size = 4
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.md]
trim_trailing_whitespace = false
# A minimum of 3 spaces is required for numbered lists
# in markdown.
indent_size = 4

[*.yml]
[*.yaml]
indent_style = space
indent_size = 4

[*.json]
indent_style = space
indent_size = 4

Are there any other relevant .editorconfig files in your project? Yes / No

No

Visual Studio Code Setting Default User Workspace
editor.insertSpaces true ____ ____
editor.tabSize 4 _ _
editor.trimAutoWhitespace true ____ ____
files.autoSave "off" "___" "___"
files.insertFinalNewline false _____ _____
files.trimTrailingWhitespace false _____ _____

File opened

./foo.yaml

Expected behavior

indent_size = 4
indent_style = space

Actual behavior

indent_size = 4
indent_style = tab

Additional comments or steps to reproduce

When indent_style is space, this plugin should instruct the editor to use spaces for indentation. When indent_style is tab, this plugin should instruct the editor to use tabs for indentation. This plugin should not require a global install of the editorconfig dependency, instead it should rely on the local editorconfig dependency relative to a root level .editorconfig file. Relying on a global dependency could (but probably won't) cause issues with different versions of editorconfig dependencies in different projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant