From 8d2383556b2e9e6d6938a344b98b8dadd9d9a71c Mon Sep 17 00:00:00 2001
From: Rob Brackett <rob@robbrackett.com>
Date: Mon, 14 Aug 2017 12:18:15 -0700
Subject: [PATCH] Clean up unused vars (we are now lint-free!)

---
 .eslintrc.json                                | 6 ++++++
 src/components/annotation-form.jsx            | 1 -
 src/components/change-view.jsx                | 1 -
 src/components/diff-item.jsx                  | 1 -
 src/components/login-form.jsx                 | 1 -
 src/components/page-details.jsx               | 4 ++--
 src/components/page-list.jsx                  | 2 --
 src/components/select-version.jsx             | 3 +--
 src/components/side-by-side-rendered-diff.jsx | 1 -
 src/components/web-monitoring-ui.jsx          | 6 +++---
 10 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index 9f3d61e9..43e8ec18 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -17,6 +17,12 @@
       "error",
       "unix"
     ],
+    "no-unused-vars": [
+      "error",
+      // Allow functions to include the full signature of a protocol they adhere
+      // to, even if they don’t use some args.
+      {"args": "none"}
+    ],
     "quotes": [
       "error",
       "single"
diff --git a/src/components/annotation-form.jsx b/src/components/annotation-form.jsx
index 13939ab5..bbd7bdf8 100644
--- a/src/components/annotation-form.jsx
+++ b/src/components/annotation-form.jsx
@@ -1,6 +1,5 @@
 import React from 'react';
 import Tooltip from 'react-tooltip';
-import { Version } from '../services/web-monitoring-db';
 
 /**
  * @typedef {Object} AnnotationFormProps
diff --git a/src/components/change-view.jsx b/src/components/change-view.jsx
index b6806661..a13e2c39 100644
--- a/src/components/change-view.jsx
+++ b/src/components/change-view.jsx
@@ -1,7 +1,6 @@
 import PropTypes from 'prop-types';
 import React from 'react';
 import {Link} from 'react-router-dom';
-import {diffTypes} from '../constants/diff-types';
 import WebMonitoringDb from '../services/web-monitoring-db';
 import WebMonitoringApi from '../services/web-monitoring-api';
 import AnnotationForm from './annotation-form';
diff --git a/src/components/diff-item.jsx b/src/components/diff-item.jsx
index f288550c..f829e32e 100644
--- a/src/components/diff-item.jsx
+++ b/src/components/diff-item.jsx
@@ -9,7 +9,6 @@ import React from 'react';
 export default class DiffItem extends React.Component {
   render () {
     const { data, onSelect } = this.props;
-    const diff = data;
 
     // here we do inline style-editing and class switching.
     // in the real world it's probably a good idea to associate
diff --git a/src/components/login-form.jsx b/src/components/login-form.jsx
index 7cb4997c..35d73b66 100644
--- a/src/components/login-form.jsx
+++ b/src/components/login-form.jsx
@@ -1,6 +1,5 @@
 import PropTypes from 'prop-types';
 import React from 'react';
-import {RouteComponentProps} from 'react-router-dom';
 import WebMonitoringDb from '../services/web-monitoring-db';
 
 /**
diff --git a/src/components/page-details.jsx b/src/components/page-details.jsx
index 09538e70..20fe5d56 100644
--- a/src/components/page-details.jsx
+++ b/src/components/page-details.jsx
@@ -1,7 +1,7 @@
 import PropTypes from 'prop-types';
 import React from 'react';
 import {Link, Redirect} from 'react-router-dom';
-import WebMonitoringDb, {Page} from '../services/web-monitoring-db';
+import WebMonitoringDb from '../services/web-monitoring-db';
 import ChangeView from './change-view';
 
 /**
@@ -134,7 +134,7 @@ export default class PageDetails extends React.Component {
    * - Render a message indicating no change to render (if there's no
    *   valid change we could navigate to)
    * @private
-   * @returns {React.Component}
+   * @returns {JSX.Element}
    */
   _renderChange () {
     const page = this.state.page;
diff --git a/src/components/page-list.jsx b/src/components/page-list.jsx
index 3701d348..0c01925c 100644
--- a/src/components/page-list.jsx
+++ b/src/components/page-list.jsx
@@ -1,6 +1,4 @@
 import React from 'react';
-import {Link, RouteComponentProps} from 'react-router-dom';
-import {Page} from '../services/web-monitoring-db';
 
 /**
  * These props also inherit from React Router's RouteComponent props
diff --git a/src/components/select-version.jsx b/src/components/select-version.jsx
index a2025be6..612930b6 100644
--- a/src/components/select-version.jsx
+++ b/src/components/select-version.jsx
@@ -1,5 +1,4 @@
 import React from 'react';
-import {Version} from '../services/web-monitoring-db';
 
 const dateFormatter = new Intl.DateTimeFormat('en-US', {
   day: 'numeric',
@@ -29,7 +28,7 @@ export default class SelectVersion extends React.PureComponent {
       this.props.onChange(versions.find(v => v.uuid === newValue));
     };
 
-    const options = versions.map((version, index) => {
+    const options = versions.map(version => {
       return (
         <option key={version.uuid} value={version.uuid}>
           {dateFormatter.format(version.capture_time)}
diff --git a/src/components/side-by-side-rendered-diff.jsx b/src/components/side-by-side-rendered-diff.jsx
index 1f7aa868..03f0e625 100644
--- a/src/components/side-by-side-rendered-diff.jsx
+++ b/src/components/side-by-side-rendered-diff.jsx
@@ -1,5 +1,4 @@
 import React from 'react';
-import {Page} from '../services/web-monitoring-db';
 
 /**
  * @typedef {Object} SideBySideRenderedDiffProps
diff --git a/src/components/web-monitoring-ui.jsx b/src/components/web-monitoring-ui.jsx
index a4f7e3d3..e17f9860 100644
--- a/src/components/web-monitoring-ui.jsx
+++ b/src/components/web-monitoring-ui.jsx
@@ -1,10 +1,10 @@
 import PropTypes from 'prop-types';
 import React from 'react';
 import AriaModal from 'react-aria-modal';
-import {BrowserRouter as Router, Link, Route} from 'react-router-dom';
+import {BrowserRouter as Router, Route} from 'react-router-dom';
 import bindComponent from '../scripts/bind-component';
 import WebMonitoringApi from '../services/web-monitoring-api';
-import WebMonitoringDb, {Page} from '../services/web-monitoring-db';
+import WebMonitoringDb from '../services/web-monitoring-db';
 import LoginForm from './login-form';
 import NavBar from './nav-bar';
 import PageDetails from './page-details';
@@ -63,7 +63,7 @@ export default class WebMonitoringUi extends React.Component {
         this.setState({user: api.userData});
         if (loggedIn) {
           return localApi.getPagesForUser(api.userData.email)
-            .catch(error => {
+            .catch(() => {
               // TODO: Handle 'user not found' in a better way
               // than just showing default list
               return api.getPages();