From 1936df8dd33d1b968f0baaa31090d13ebf0621f3 Mon Sep 17 00:00:00 2001
From: Rob Brackett <rob@robbrackett.com>
Date: Fri, 21 Feb 2025 12:28:22 -0800
Subject: [PATCH] Allow (but still check) bad translations in CI

This allows the translations lint/test step to fail without failing the whole job and thus blocking the build. It logs some summary info for the workflow so it's possible to keep an eye on the status of translation issues.
---
 .github/workflows/build-client.yml | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/build-client.yml b/.github/workflows/build-client.yml
index ed1f929a..83fbbb75 100644
--- a/.github/workflows/build-client.yml
+++ b/.github/workflows/build-client.yml
@@ -118,7 +118,25 @@ jobs:
         run: npm ci
 
       - name: Spanish translation test
-        run: npm run test:intl-translations
+        # TODO: Make this error fatal when we have a strategy for translations!
+        # 
+        # Right now, we are trying to quickly iterate on this community
+        # deployment of CEJST and don't have a clear process or strategy around
+        # how to handle translations. We're keeping this check in so we have an
+        # eye on what is or isn't translated, but missing or deprecated
+        # non-English strings should not stop the build and prevent us from
+        # merging or deploying changes.
+        continue-on-error: true
+        run: |
+          npm run test:intl-translations
+          if [ "${?}" -eq 0 ]; then
+            echo "✅ Translations: In good shape." >> $GITHUB_STEP_SUMMARY
+          else
+            echo "⚠️ Translations: English and Spanish are mismatched." >> $GITHUB_STEP_SUMMARY
+            echo ""  >> $GITHUB_STEP_SUMMARY
+            echo "See *tranlsations* job logs for details."  >> $GITHUB_STEP_SUMMARY
+          fi
+
 
   deploy:
     if: github.ref == 'refs/heads/main'