Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to filter dependencies vs devDependencies #796

Open
benmccann opened this issue Jun 23, 2024 · 9 comments
Open

Ability to filter dependencies vs devDependencies #796

benmccann opened this issue Jun 23, 2024 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@benmccann
Copy link

I would love the ability to filter for dependants that show up in dependencies in package.json and exclude packages where it appears in devDependencies

@andrew
Copy link
Member

andrew commented Jun 24, 2024

Deploying a version of this now for testing, not sure how performant the counting of the kind filters will be just yet, might need to add some caching.

@andrew
Copy link
Member

andrew commented Jun 24, 2024

@andrew
Copy link
Member

andrew commented Jun 24, 2024

Note that there may be some crossover between kinds (a package that shows up for multiple kinds) if different versions of the package use that dependency in different ways (runtime vs dev for example).

If filtering by latest (from #794) there shouldn't be any crossover as it's only considering one version per package.

@andrew andrew self-assigned this Jun 24, 2024
@andrew andrew added the enhancement New feature or request label Jun 24, 2024
@andrew
Copy link
Member

andrew commented Jun 24, 2024

I'm also going to add an API endpoint to be able to fetch a list of kinds and counts.

@benmccann
Copy link
Author

OMG, thank you! This list is exactly what I've been looking for forever!!

https://packages.ecosyste.ms/registries/npmjs.org/packages/deep-equal/dependent_packages?latest=true&order=desc&sort=downloads

@benmccann
Copy link
Author

benmccann commented Jun 24, 2024

There may be some issue still. If you click the link from my last comment fast-equals and deep-diff are listed, but when I look at the package.json for those packages I only see it in devDependencies

@andrew
Copy link
Member

andrew commented Jun 24, 2024

@benmccann the latest parameter isn't persisted right now when you click on the sidebar links, so the url for that view would be https://packages.ecosyste.ms/registries/npmjs.org/packages/deep-equal/dependent_packages?kind=runtime&latest=true

I'll make sure latest sticks around though those menu clicks when I add the UI toggle shortly.

@andrew
Copy link
Member

andrew commented Jun 24, 2024

Just deployed that now.

@andrew
Copy link
Member

andrew commented Jun 24, 2024

Also added a new dependent_package_kinds api endpoint: https://packages.ecosyste.ms/api/v1/registries/npmjs.org/packages/deep-equal/dependent_package_kinds

Which also accepts latest: https://packages.ecosyste.ms/api/v1/registries/npmjs.org/packages/deep-equal/dependent_package_kinds?latest=true

cc @voxpelli as you may find this and the kind filter parameter I just added to the dependent_packages api endpoint useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants