Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP REST Client should implement a type of connection pooling #242

Open
bpaskin opened this issue Jan 3, 2020 · 7 comments
Open

MP REST Client should implement a type of connection pooling #242

bpaskin opened this issue Jan 3, 2020 · 7 comments
Labels
Milestone

Comments

@bpaskin
Copy link

bpaskin commented Jan 3, 2020

Currently Java allows for a number of maximum connections to destinations based on the property http.maxConnections and can be kept alive using http.keepAlive. However, this may not be fined grained enough for applications that need to communicate with multiple systems that will have varying degrees of connections allowed.

It would be a good feature to have some sort of connection pooling for each destination, similar to that of datasources, that allow for:

  • number of connections
  • keep-alive timeout
  • maximum request time before throwing an error and disconnecting
  • validation of connections
    etc

-Brian

@kenfinnigan
Copy link
Contributor

I believe most implementations of MP REST Client have connection pooling in their underlying HTTP Client, but we could investigate adding properties to "standardize" how to it's configured.

For maximum request time, that's handled with the existing connectTimeout and readTimeout properties, along with combining it with MP Fault Tolerance annotations

@bpaskin
Copy link
Author

bpaskin commented Jan 3, 2020

Agreed with the connectionTimeout and readTimeout, but unfortunately not al devs follow good programming practices.

@Kiiv
Copy link

Kiiv commented Sep 27, 2022

Really interested in this feature too. I'm using Open Liberty and I don't find any solution to access the underlying HTTP Client and set max connections :s

@tushar-1728
Copy link

So, do we any update on the implementation of this feature?

@Emily-Jiang
Copy link
Member

Emily-Jiang commented Oct 30, 2022

@njr-11 @andymc12 any thoughts on this?

@njr-11
Copy link
Contributor

njr-11 commented Oct 31, 2022

@njr-11 @andymc12 any thoughts on this?

For REST Client on Liberty, the correct contact is @jim-krueger or @WhiteCat22

@jim-krueger
Copy link
Contributor

Connection pooling for Open Liberty today is a per destination size. Standardizing configuration of this is something that maybe should be considered, but I'm not sure if this belongs with microprofile-rest-client. I think it might be a better candidate for RESTful Web Services.

@jclingan jclingan added this to the Future milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants