Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health support #47

Open
cescoffier opened this issue Jun 11, 2019 · 6 comments · May be fixed by #130
Open

Health support #47

cescoffier opened this issue Jun 11, 2019 · 6 comments · May be fixed by #130
Milestone

Comments

@cescoffier
Copy link
Contributor

No description provided.

@cescoffier cescoffier added this to the 1.1 milestone Jun 11, 2019
@Emily-Jiang
Copy link
Member

Emily-Jiang commented Oct 16, 2019

This is the integration with MP Health by providing implicit readiness check - ready to receive traffic; liveness Health procedure - to be killed if DOWN.

@Emily-Jiang Emily-Jiang removed this from the 1.1 milestone Oct 16, 2019
lamtrhieu pushed a commit to lamtrhieu/microprofile-reactive-messaging that referenced this issue Nov 8, 2019
…ivex.rxjava2-rxjava-2.2.6

Bump rxjava from 2.2.5 to 2.2.6
@Emily-Jiang Emily-Jiang added this to the 1.1 milestone Jul 22, 2020
@Emily-Jiang
Copy link
Member

This will be just a spec statement regarding the integration with MP Health.

@cescoffier cescoffier modified the milestones: 1.1, 1.2 Feb 11, 2021
@danielkec
Copy link
Contributor

This will be just a spec statement regarding the integration with MP Health.

Initially this was proposed as integration with MP Health by providing implicit checks.
Such implicit check I would imagine having features like this:

  • readiness is considered UP when onSubscribe signal has been registered on all the channels
  • liveness is considered DOWN when onError, onComplete or cancel has been detected on any channel
  • specified check name
  • optional configuration for including/excluding channels

@Emily-Jiang Why leaving the idea?

@Emily-Jiang
Copy link
Member

I don't have any objections to take it in. We need a PR to update spec and add tcks. Feel free to contribute @danielkec

danielkec added a commit to danielkec/microprofile-reactive-messaging that referenced this issue Feb 24, 2021
@danielkec danielkec linked a pull request Feb 24, 2021 that will close this issue
@danielkec
Copy link
Contributor

@Emily-Jiang PR #130 is ready

@Emily-Jiang
Copy link
Member

Thank you @danielkec for proposing this PR. It serves a good talking point. I took a look at this PR and referred back to this issue. This issue needs a bit more description on describing what behaviour we want to define. What we are going to do with nack? Are we going to consider livessness to be DOWN when there is one channel has issues? At the moment, you introduce an opt out approach, should we use opt-in approaches? @cescoffier can you please comment on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants