-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename outcome to status #127
Rename outcome to status #127
Conversation
This is related to microprofile#125 Signed-off-by: Clement Escoffier <[email protected]>
Signed-off-by: Clement Escoffier <[email protected]>
Signed-off-by: Clement Escoffier <[email protected]>
Signed-off-by: Clement Escoffier <[email protected]>
Signed-off-by: Clement Escoffier <[email protected]>
README.adoc
Outdated
|
||
Within CDI contexts, beans that implement `HealthCheck` and annotated with `@Health` are discovered automatically and are invoked by the framework or runtime when the outermost protocol entry point (i.e. `http://HOST:PORT/health`) receives an inbound request. | ||
Within CDI contexts, beans that implement `HealthCheck` are discovered automatically and are invoked by the framework or runtime when the outermost protocol entry point (i.e. `http://HOST:PORT/health`) receives an inbound request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous sentence asks to annotated with @health. You should not change this under this issue though. We can discuss this under a different issue on whether it is necessary to require @Health
. I see there is no point either. However, we need to discuss this under a different issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more a cleanup as @Health
has been deprecated in the last version of the spec. I will revert this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Clement Escoffier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @cescoffier !
This change breaks service meshes. Can we revert most of these changes? The miscellaneous cleanups are fine... |
Related to #125
This PR:
outcome
withstatus
as discussed in Revisit the message body of health #125state
withstatus
as discussed in Revisit the message body of health #125@Health
annotation from the main README file