Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create branches for all specs #81

Open
AndyGee opened this issue Oct 14, 2016 · 3 comments
Open

Create branches for all specs #81

AndyGee opened this issue Oct 14, 2016 · 3 comments
Assignees
Milestone

Comments

@AndyGee
Copy link
Contributor

AndyGee commented Oct 14, 2016

Each spec that might make it into MP should have a branch

@karianna karianna added this to the 1.0.0 milestone Oct 14, 2016
@AndyGee AndyGee self-assigned this Oct 14, 2016
@kenfinnigan
Copy link
Contributor

I'm not sure this is the best approach.

There will be half a dozen or so items that likely fall into this category, and keeping all those branches in sync with master as master changes would be an extremely time consuming maintenance burden.

I would prefer that branches for including specs into the demo are only created once a spec has been agreed to be a part of MicroProfile.

Also from the perspective that how these specs are integrated needs to be correctly architected to ensure the overall project shows off the right things.

@AndyGee AndyGee added the ready label Oct 14, 2016
@AndyGee
Copy link
Contributor Author

AndyGee commented Oct 20, 2016

Those branches would only be there for prototyping and hacking. Once a spec is in, then the branch is out. It's more about accepting PRs away from the master. WDYT?

@kenfinnigan
Copy link
Contributor

I'm not sure what the common view might be, but my thoughts were that we wouldn't be creating branches/including things into the demo app until such time as a specification has been "approved" for inclusion in MicroProfile.

Without this approach, it's very easy for a large number of branches to be present which are for specifications that haven't, and may never, make it into MicroProfile.

I would see any examples or experimentation to show how a specification's implementation works being present within the repo covering the specification, as defined by the Evolution process.

It makes it harder to have a "cohesive" vision for what the demo will be if there's lots of things in flux, as opposed to:

  • New specification agreed to be included in MicroProfile
  • Architect how best to incorporate that into the demo
  • Submit PR with necessary changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants